Skip to content

fix(workbench): split legacy roots from linked global finding groups - #2702

Open
hyeonsang010716 wants to merge 1 commit into
openai:mainfrom
hyeonsang010716:fix/global-findings-legacy-root-split
Open

hyeonsang010716 wants to merge 1 commit into
openai:mainfrom
hyeonsang010716:fix/global-findings-legacy-root-split

Conversation

@hyeonsang010716

Copy link
Copy Markdown

Summary

Unscoped list-global-findings could stop responding and keep allocating memory. The SDK also uses this listing when it resolves an open finding without a scan ID.

The hang occurs when a cross-target finding group is rooted at a legacy occurrence. This requires a target with a scan that has no repository generation and with scans in more than one generation. A same-target match must link the legacy occurrence to a current one, and a linked worktree match must add another target. When legacy rows are split back to their target, they map to the group's own identity and are appended to the list being iterated.

Changes

  • Take each cross-target group out of the grouping before its legacy rows are redistributed, and project its current rows separately. Legacy rows still join an existing group for their target.
  • Keeping the colliding legacy rows in the cross-target group would also end the loop. It would also apply their triage decision to the linked current finding, which global comparisons avoid.
  • Add a regression test for this state. It expects a closed legacy finding and a separate open linked finding.

Testing

  • The new test passes. On the base revision it did not finish within 20 seconds.
  • The native index, native index query, scan history, feedback, and Standard/Deep result suites passed on macOS with Python 3.13 (420 tests). The native index query suite also passed with Python 3.10.
  • The full plugin suite passed except for 32 tests in test_workbench_target.py and test_sarif_projection.py. Those tests fail the same way on the base revision in this macOS environment.
  • Ruff lint and formatting, build:ci, the plugin source compatibility check, and its nine tests passed.

Risk and rollout

Only unscoped global projections whose groups contain current occurrences from more than one target are affected. Scoped projections, stored data, and the output format are unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

A cross-target finding group rooted at a legacy occurrence mapped its
legacy rows back to the group's own identity, so the split loop appended
them to the list it was iterating and never returned. Take each split
group out of the grouping first and project its current rows separately.
@github-actions github-actions Bot added the bug Something isn't working label Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant