Repository navigation
fix(workbench): split legacy roots from linked global finding groups - #2702
Open
hyeonsang010716 wants to merge 1 commit into
Open
hyeonsang010716 wants to merge 1 commit into
hyeonsang010716 wants to merge 1 commit into
Conversation
A cross-target finding group rooted at a legacy occurrence mapped its legacy rows back to the group's own identity, so the split loop appended them to the list it was iterating and never returned. Take each split group out of the grouping first and project its current rows separately.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unscoped
list-global-findingscould stop responding and keep allocating memory. The SDK also uses this listing when it resolves an open finding without a scan ID.The hang occurs when a cross-target finding group is rooted at a legacy occurrence. This requires a target with a scan that has no repository generation and with scans in more than one generation. A same-target match must link the legacy occurrence to a current one, and a linked worktree match must add another target. When legacy rows are split back to their target, they map to the group's own identity and are appended to the list being iterated.
Changes
Testing
test_workbench_target.pyandtest_sarif_projection.py. Those tests fail the same way on the base revision in this macOS environment.build:ci, the plugin source compatibility check, and its nine tests passed.Risk and rollout
Only unscoped global projections whose groups contain current occurrences from more than one target are affected. Scoped projections, stored data, and the output format are unchanged.
Public disclosure review