Tab text translation issue solved#2376
Merged
IOhacker merged 1 commit intoopenMF:mainfrom Apr 6, 2025
Merged
Conversation
steinwinde
added a commit
to steinwinde/web-app
that referenced
this pull request
Apr 9, 2025
Fixes tab titles both in English and other languages. From what I can tell openMF#2376 worked only for 3 pages - those 3 with translations in labels.titles.*. On the other hand, it did not even work for English on most pages. In addition to that, openMF#2376 removed code regarding top 100 user activities, without any explanation. The PR here is meant to fix all of that and hopefully doesn't affect openMF#2385. FIXES: WEB-130, WEB-40
IOhacker
pushed a commit
that referenced
this pull request
Apr 12, 2025
Fixes tab titles both in English and other languages. From what I can tell #2376 worked only for 3 pages - those 3 with translations in labels.titles.*. On the other hand, it did not even work for English on most pages. In addition to that, #2376 removed code regarding top 100 user activities, without any explanation. The PR here is meant to fix all of that and hopefully doesn't affect #2385. FIXES: WEB-130, WEB-40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab text also gets displayed with the correct mapping of its page titles now.
