Fix Windows admin permission fallback to prioritize STREAM before mbw #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Windows functions (
WinsatTestandWindowsDDTest) had inconsistent fallback behavior compared to Linux/macOS when no admin permissions were detected. While Linux/macOS functions would first attempt the STREAM method before falling back to mbw, Windows functions would directly use mbw, missing the opportunity to use the higher-performance STREAM test.This inconsistency meant Windows users without admin privileges couldn't benefit from STREAM testing even when the binaries were available.
Solution
Cross-Platform StreamTest Implementation
StreamTestandparseStreamOutputfunctions frommacos_linux_mem.goto a new cross-platformstream.gofile.exeextensions:Updated Windows Functions
Modified both
WinsatTestandWindowsDDTestto follow the same fallback pattern as Linux/macOS:Testing
Impact
Windows users without admin privileges now have the same testing priority as Linux/macOS users:
This ensures consistent, optimal memory testing across all supported platforms.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
hits.spiritlhl.net/home/REDACTED/.cache/go-build/39/3903d80438db21a5bd2ae033e5b068e9e20cfca4e9cb50f1788ed73dff28f37f-d/main -m auto -l en(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.