Repository navigation
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Animated wallpapers can make the background size probe concatenate dimensions from multiple frames. A two-frame 20×10 GIF produces
20 1020 10; the shell reads that as 20×1020 and asks Qt'sPreserveAspectCropimage to decode at that size. A bounded Qt reproduction expanded this 200-pixel image to 2040×1020 pixels. Larger wallpapers can therefore request enormous allocations, matching the failure mechanism in #15179.Probe only frame zero, matching the still image the shell displays. The original wallpaper path remains the cache key and image source. The regression runs the actual probe, result parser and decode-size functions against real tiny animated/static GIF, PNG, JPEG and WebP fixtures, including a filename with spaces, brackets and Unicode.
Validation:
4c1b4cb3with height 1020 instead of 10; all 15 assertions pass with the fix.git diff --checkpass../test/all: CLI passed; 10 of 385 shell test files failed and 28 had skipped checks. All 10 failures reproduce on unchanged4c1b4cb3in the same headless environment (missing companion packaging checkout, existing migration/assertion failures, and a Lua fixture missingget_windows). No candidate-only failure was found.Fixes #15179.