[IMP] core: _search_display_name replaces _name_search#174967
Closed
kmagusiak wants to merge 2 commits intoodoo:masterfrom
Closed
[IMP] core: _search_display_name replaces _name_search#174967kmagusiak wants to merge 2 commits intoodoo:masterfrom
kmagusiak wants to merge 2 commits intoodoo:masterfrom
Conversation
Contributor
|
|
92d0ded to
d7ccd85
Compare
Contributor
|
Merge method set to rebase and fast-forward. |
Contributor
|
@kmagusiak @rco-odoo linked pull request(s) odoo/documentation#10856, odoo/enterprise#67592 not ready. Linked PRs are not staged until all of them are ready. |
Contributor
|
@kmagusiak @rco-odoo linked pull request(s) odoo/documentation#10856 not ready. Linked PRs are not staged until all of them are ready. |
b41f0ec to
0b848e4
Compare
kmagusiak
added a commit
to odoo/documentation
that referenced
this pull request
Sep 5, 2024
Aligning the behaviour of name searches to other fields. Since the displayed name is `display_name`, implementing `search` on it gives the domain to use for searches by name. The function `_name_search` has therefore no reason to exist anymore. We keep the function `name_search` which is public and move the logic linked to displaying a limited number of records there. task-3484032
…model We simply introduce a special case: using "x_id.id" doesn't recurse on the field's comodel. It simply uses the value of the many2one id itself.
0b848e4 to
8339326
Compare
kmagusiak
added a commit
to odoo/documentation
that referenced
this pull request
Sep 6, 2024
Member
|
@robodoo rebase-ff r+ |
Contributor
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Sep 6, 2024
Aligning the behaviour of name searches to other fields. Since the displayed name is `display_name`, implementing `search` on it gives the domain to use for searches by name. The function `_name_search` has therefore no reason to exist anymore. We keep the function `name_search` which is public and move the logic linked to displaying a limited number of records there. task-3484032 Part-of: #174967 Related: odoo/enterprise#67592 Related: odoo/documentation#10856 Signed-off-by: Raphael Collet <rco@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 6, 2024
…model We simply introduce a special case: using "x_id.id" doesn't recurse on the field's comodel. It simply uses the value of the many2one id itself. closes #174967 Related: odoo/enterprise#67592 Related: odoo/documentation#10856 Signed-off-by: Raphael Collet <rco@odoo.com>
robodoo
pushed a commit
to odoo/documentation
that referenced
this pull request
Sep 6, 2024
odoo/odoo#174967 closes #10856 Related: odoo/enterprise#67592 Signed-off-by: Raphael Collet <rco@odoo.com>
ryv-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Sep 26, 2024
Since odoo#174967, use name_search on task doesn't work correctly: "Non-stored field project.task.display_name cannot be searched" Which makes any many2one toward it unsearchable. The field display_name is only added when no display_name are set on the model. It means that every model 'overriding' display_name should also included `search='_search_display_name'`. Two solution: - add `display_name` has a normal field to be extended as usual. (import nightmare to fix) - just add `search='_search_display_name'` on every model taht have display_name =field...
lef-adhoc
added a commit
to adhoc-dev/odoo-module-migrator
that referenced
this pull request
Oct 29, 2024
…ed by '_search_display_name' More info here: odoo/odoo#174967
lef-adhoc
added a commit
to adhoc-dev/odoo-module-migrator
that referenced
this pull request
Oct 29, 2024
…ed by '_search_display_name' More info here: odoo/odoo#174967
LucasTran380381
pushed a commit
to trobz/odoo-module-migrator
that referenced
this pull request
Nov 22, 2024
…ed by '_search_display_name' More info here: odoo/odoo#174967
bosd
pushed a commit
to bosd/odoo-module-migrator
that referenced
this pull request
Jan 2, 2025
…ed by '_search_display_name' More info here: odoo/odoo#174967
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligning the behaviour of name searches to other fields. Since the displayed name is
display_name, implementingsearchon it gives the domain to use for searches by name.The function
_name_searchhas therefore no reason to exist anymore. We keep the functionname_searchwhich is public and move the logic linked to displaying a limited number of records there.odoo/enterprise#67592
odoo/documentation#10856
task-3484032
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr