Skip to content

Conversation

@iampavelkozlov
Copy link

No description provided.

@iampavelkozlov iampavelkozlov requested a review from a team as a code owner November 13, 2023 10:21
@deepmap-marcinr deepmap-marcinr merged commit 11ea4d6 into oapi-codegen:main Nov 13, 2023
@deepmap-marcinr
Copy link
Contributor

Thank you.

@jamietanna
Copy link
Member

Thanks for raising this @itpavelkozlov - to confirm, did you take the code that @renom wrote in #14 or was your implementation from scratch?

deepmap-marcinr pushed a commit to deepmap-marcinr/oapi-codegen-runtime that referenced this pull request Nov 14, 2023
Pull request oapi-codegen#19 introduced
an extra parameter into a widely used function, which would break existing
generated code with the next release.

Restore the previous function to its old signature, and add a new one
which takes additional options in an options structure.
jamietanna pushed a commit that referenced this pull request Nov 14, 2023
Pull request #19 introduced
an extra parameter into a widely used function, which would break existing
generated code with the next release.

Restore the previous function to its old signature, and add a new one
which takes additional options in an options structure.

Co-authored-by: marcinromaszewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants