Repository navigation
sqlite: mark as stable - #67654
sqlite: mark as stable#67654christianaurichzm wants to merge 1 commit into
Conversation
|
Review requested:
|
Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
75cde4b to
6a723dd
Compare
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
Done, thanks. It’s |
aduh95
left a comment
There was a problem hiding this comment.
Why would we need --no-sqlite?
|
Yep, I'd much prefer a doc-only change here, and making |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67654 +/- ##
==========================================
- Coverage 90.71% 90.60% -0.12%
==========================================
Files 801 801
Lines 280906 280969 +63
Branches 54249 54228 -21
==========================================
- Hits 254832 254577 -255
- Misses 16246 16576 +330
+ Partials 9828 9816 -12
🚀 New features to boost your workflow:
|
eba104e to
6a723dd
Compare
|
Done, it’s back to the doc-only change. I’ll open the semver-major PR for |
aduh95
left a comment
There was a problem hiding this comment.
No need for Jenkins CI on a doc-only PR
node:sqlitehas been a release candidate since #61262, where @cjihrig asked for a decision on the async API before marking it stable. I followed up after the rename in #65988 and got the go-ahead. I also flagged #67353 and #67427 there, since some of their options would be semver-major after this.The CLI docs drop "experimental" from the
--no-experimental-sqlitedescription, as #45684 did for fetch. Making--experimental-sqlitea no-op is semver-major, so that'll be a separate PR.Thanks @TrevorBurnham for the checklist in #57445, @araujogui and @trivikr for keeping it updated, and everyone who worked on
node:sqlite.Notable change
The built-in
node:sqlitemodule is now stable, after being a release candidate since v25.7.0 and v24.15.0. It lets applications work with SQLite databases without installing a native addon.Fixes: #57445