Skip to content

test: skip fs-watch-recursive-delete-race on AIX - #65698

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:skip-aix-failing-test
Sep 1, 2026
Merged

test: skip fs-watch-recursive-delete-race on AIX#65698
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:skip-aix-failing-test

Conversation

@aduh95

@aduh95 aduh95 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Refs: #65697

@aduh95
test: skip fs-watch-recursive-delete-race on AIX
1a440ba 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 1, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76804/

panva pushed a commit that referenced this pull request Sep 1, 2026
@aduh95 @panva
test: skip fs-watch-recursive-delete-race on AIX
24c7c30 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65698
Refs: #65697
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
@panva

This comment was marked as outdated.

Sign in to view
@panva panva closed this Sep 1, 2026
@panva panva mentioned this pull request Sep 1, 2026
Merged
@aduh95
aduh95 deleted the skip-aix-failing-test branch September 1, 2026 08:39
aduh95
aduh95 commented Sep 1, 2026
View reviewed changes
Comment thread test/parallel/parallel.status Outdated
@aduh95
aduh95 restored the skip-aix-failing-test branch September 1, 2026 08:47
@aduh95 aduh95 reopened this Sep 1, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76809/

mcollina
mcollina approved these changes Sep 1, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95
aduh95 merged commit f9ab994 into nodejs:main Sep 1, 2026
54 of 63 checks passed
@aduh95

aduh95 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Landed in f9ab994

@aduh95
aduh95 deleted the skip-aix-failing-test branch September 1, 2026 10:01
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (242909f) to head (a249dda).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #65698   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         754      754           
  Lines      256395   256395           
  Branches    48500    48502    +2     
=======================================
+ Hits       230922   230932   +10     
- Misses      16574    16575    +1     
+ Partials     8899     8888   -11

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 added a commit that referenced this pull request Sep 3, 2026
@aduh95
test: skip fs-watch-recursive-delete-race on AIX
1304474 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65698
Refs: #65697
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@panva panva panva approved these changes
@pimterry pimterry pimterry approved these changes

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @panva @mcollina @pimterry