Skip to content

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Aug 2, 2024

I'd like to nominate @KevinEady a triager. Kevin has contributed to node-addon-api for a long time and I believe his help will be beneficial to the work in the core repo as well.

/cc @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 2, 2024
@avivkeller avivkeller added the meta Issues and PRs related to the general management of the project. label Aug 4, 2024
@aduh95
Copy link
Contributor

aduh95 commented Aug 6, 2024

@KevinEady is it something that you'd be interested in?

@vmoroz
Copy link
Member

vmoroz commented Aug 6, 2024

+1.
@KevinEady is one of the main contributors to the Node-API. E.g. see his presentation with @gabrielschulhof : https://www.youtube.com/watch?v=4cCSPw-I0GE and his contributions to nodejs/node-addon-api. It was surprising to learn last week in the Node-API meeting that he is not a Node.js collaborator.

@KevinEady
Copy link
Contributor

Hi @aduh95 ,

Yes, absolutely. My knowledge of the Node.js architecture is pretty narrow to node-addon-api (and a little less so, the underlying Node-API) but I do contribute in what ways I can (see: PR search) 😄 I've taken a look at the triaging guide and those responsibilities look good to me.

Thanks, Kevin

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 277ed9f into nodejs:main Aug 6, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in 277ed9f

@legendecas legendecas deleted the doc/triager branch August 6, 2024 11:53
@mhdawson
Copy link
Member

mhdawson commented Aug 6, 2024

Yay!

@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants