Skip to content

esm: improve defaultResolve performance #53711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 1 commit into from
Jul 6, 2024
Merged

esm: improve defaultResolve performance #53711

aduh95 merged 1 commit into from
Jul 6, 2024

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jul 3, 2024

Reduces try/catch by avoiding functions that can throw. Introduces URLParse by replacing new URL()

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2024

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jul 3, 2024
@anonrig anonrig requested review from GeoffreyBooth and aduh95 July 3, 2024 13:59
mcollina
mcollina approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60017/

@aduh95
Copy link
Contributor

aduh95 commented Jul 4, 2024

Looks like Resume CI is not available. Since Windows was the only one with a non-flaky failure, I've retried only this one.
Windows CI: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/28442/

@targos
Copy link
Member

targos commented Jul 6, 2024

Windows CI passed

@aduh95 aduh95 merged commit b3b8349 into nodejs:main Jul 6, 2024
@aduh95
Copy link
Contributor

aduh95 commented Jul 6, 2024

Landed in b3b8349

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig @aduh95
esm: improve defaultResolve performance
b8dd273 
PR-URL: #53711
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig @aduh95
esm: improve defaultResolve performance
1a21e0f 
PR-URL: #53711
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@anonrig @nodejs-github-bot @aduh95 @targos @mcollina @jasnell @GeoffreyBooth @marco-ippolito