Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jan 31, 2016

No description provided.

@Trott Trott added test Issues and PRs related to the tests. i18n-api Issues and PRs related to the i18n implementation. lts-watch-v4.x labels Jan 31, 2016
@targos
Copy link
Member

targos commented Jan 31, 2016

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

@Trott
Copy link
Member Author

Trott commented Feb 2, 2016

Trott added a commit to Trott/io.js that referenced this pull request Feb 2, 2016
PR-URL: nodejs#4988
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 2, 2016

Landed in 6504a0f

@Trott Trott closed this Feb 2, 2016
@srl295
Copy link
Member

srl295 commented Feb 3, 2016

LGTM (after the fact)

rvagg pushed a commit that referenced this pull request Feb 8, 2016
PR-URL: #4988
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4988
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #4988
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #4988
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4988
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott Trott deleted the test-intl-no-redeclare branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants