test: skip test depending on overlapped-checker when not available
#45015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Oct 15, 2022
cjihrig
approved these changes
Oct 15, 2022
lpinca
approved these changes
Oct 15, 2022
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45015 ✔ Done loading data for nodejs/node/pull/45015 ----------------------------------- PR info ------------------------------------ Title test: skip test depending on `overlapped-checker` when not available (#45015) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:skip-test-release-build -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: skip test depending on `overlapped-checker` when not available Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/45015 Reviewed-By: Rafael Gonzaga Reviewed-By: Yagiz Nizipli Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45015 Reviewed-By: Rafael Gonzaga Reviewed-By: Yagiz Nizipli Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 15 Oct 2022 13:14:25 GMT ✔ Approvals: 4 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45015#pullrequestreview-1143198383 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45015#pullrequestreview-1143215771 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45015#pullrequestreview-1143220776 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45015#pullrequestreview-1143221002 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-15T18:27:16Z: https://ci.nodejs.org/job/node-test-pull-request/47283/ - Querying data for job/node-test-pull-request/47283/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3257083627 |
Collaborator
|
Landed in bfa0040 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #45004 (comment)