doc: document optional params in napi_get_cb_info #40821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Dawson <[email protected]>
Member
Author
|
oops see there is extra stuff, fixing. |
bd3ddd9 to
6393180
Compare
Member
Author
|
Fixed |
jasnell
approved these changes
Nov 16, 2021
tniessen
approved these changes
Nov 16, 2021
VoltrexKeyva
approved these changes
Nov 16, 2021
lpinca
approved these changes
Nov 16, 2021
Member
Is there a special/specific case where we should run full Jenkins CIs for documentation/comment changes? Because we usually don't run full Jenkins CIs on these types of changes. |
Member
Author
|
@VoltrexMaster good point, I was not thinking when I started it. The github actions were good enough. |
This was referenced Nov 17, 2021
Member
Author
|
Going to land as required jobs for doc only changes have passed. |
mhdawson
added a commit
that referenced
this pull request
Nov 19, 2021
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40821 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
Author
|
Landed in a37b9c8 |
This was referenced Nov 20, 2021
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40821 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40821 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Signed-off-by: Michael Dawson <[email protected]> PR-URL: #40821 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.