doc: remove space above version picker#34768
Closed
Vap0r1ze wants to merge 1 commit intonodejs:masterfrom
Vap0r1ze:patch-2
Closed
doc: remove space above version picker#34768Vap0r1ze wants to merge 1 commit intonodejs:masterfrom Vap0r1ze:patch-2
Vap0r1ze wants to merge 1 commit intonodejs:masterfrom
Vap0r1ze:patch-2
Conversation
DerekNonGeneric
approved these changes
Aug 14, 2020
Contributor
DerekNonGeneric
left a comment
There was a problem hiding this comment.
Nice catch! Thanks for the PR. :)
Contributor
|
You may be able to circumvent this UI problem by adjusting the zoom of your browser while you wait. |
Member
|
Looks like an alternative to #34768. |
2 tasks
BridgeAR
approved these changes
Aug 16, 2020
HarshithaKP
approved these changes
Aug 17, 2020
jasnell
approved these changes
Aug 17, 2020
Member
@richardlau I assume you meant #34447 ? |
Contributor
|
That might be a useful alternative to consider, but for now, I would just add the following to the commit message when landing. We can reinvestigate the alternative later, there's likely more to be done in this area. |
Member
|
Landed in 6f0b87d, thanks for the PR! |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #34767
Before
After
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes