test: modernize test-cluster-master-error#34685
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
test: modernize test-cluster-master-error#34685addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Some stylistic changes to bring this more in line with what our tests currently look like, and add a note about general flakiness.
Collaborator
jasnell
reviewed
Aug 10, 2020
jasnell
approved these changes
Aug 10, 2020
rickyes
approved these changes
Aug 18, 2020
Member
|
Landed in 42b5f5f |
jasnell
pushed a commit
that referenced
this pull request
Aug 19, 2020
Some stylistic changes to bring this more in line with what our tests currently look like, and add a note about general flakiness. PR-URL: #34685 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
Some stylistic changes to bring this more in line with what our tests currently look like, and add a note about general flakiness. PR-URL: #34685 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
Some stylistic changes to bring this more in line with what our tests currently look like, and add a note about general flakiness. PR-URL: #34685 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
Some stylistic changes to bring this more in line with what our tests currently look like, and add a note about general flakiness. PR-URL: #34685 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
Some stylistic changes to bring this more in line with what our tests currently look like, and add a note about general flakiness. PR-URL: #34685 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some stylistic changes to bring this more in line with what our
tests currently look like, and add a note about general flakiness.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes