test: removed default message from assert.strictEqual #19660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert.strictEqual default should include a better output message.
trivikr
approved these changes
Mar 28, 2018
cjihrig
approved these changes
Mar 28, 2018
BridgeAR
approved these changes
Mar 28, 2018
TimothyGu
approved these changes
Mar 28, 2018
Trott
approved these changes
Mar 28, 2018
Member
|
Whoops, should have started a full CI... CI: https://ci.nodejs.org/job/node-test-pull-request/13902/ |
jasnell
approved these changes
Mar 29, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 29, 2018
Use the `assert.strictEqual()` default message instead of a static message to include the actual and expected value. PR-URL: nodejs#19660 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 0434bd4 🎉 @jaspal-yupana congratulations on your first commit to Node.js and to officially becoming a Node.js contributor :-) |
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
Use the `assert.strictEqual()` default message instead of a static message to include the actual and expected value. PR-URL: #19660 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2018
Use the `assert.strictEqual()` default message instead of a static message to include the actual and expected value. PR-URL: #19660 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert.strictEqual default should include a better output message.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes