Skip to content

http2,perf_hooks: perf state using AliasedBuffer #18300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kfarnung merged 0 commits into from
Jan 25, 2018
Merged

http2,perf_hooks: perf state using AliasedBuffer #18300

kfarnung merged 0 commits into from
Jan 25, 2018

Conversation

@kfarnung
Copy link
Contributor

@kfarnung kfarnung commented Jan 22, 2018 •
edited
Loading

Update performance_state to use AliasedBuffer and update usage sites.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, perf_hooks

@kfarnung kfarnung requested review from addaleax and jasnell January 22, 2018 22:19
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 22, 2018
@kfarnung
Copy link
Contributor Author

kfarnung commented Jan 22, 2018

/cc @mike-kaufman @digitalinfinity

@addaleax addaleax added http2 Issues or PRs related to the http2 subsystem. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Jan 22, 2018
@kfarnung
Copy link
Contributor Author

kfarnung commented Jan 22, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12668/

@kfarnung
Copy link
Contributor Author

kfarnung commented Jan 23, 2018 •
edited
Loading

CI rerun: https://ci.nodejs.org/job/node-test-pull-request/12689/

Looks like the Windows leg is hitting #18269. Everything else is passing.

@kfarnung
Copy link
Contributor Author

kfarnung commented Jan 24, 2018

@jasnell do you have a moment to take a look?

@kfarnung kfarnung self-assigned this Jan 24, 2018
@kfarnung
Copy link
Contributor Author

kfarnung commented Jan 24, 2018 •
edited
Loading

Final (hopefully) rerun: https://ci.nodejs.org/job/node-test-pull-request/12712/

Looks like there are a couple of unrelated issues.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2018
@kfarnung kfarnung closed this Jan 25, 2018
@kfarnung kfarnung merged commit be2cbcc into nodejs:master Jan 25, 2018
@kfarnung
Copy link
Contributor Author

kfarnung commented Jan 25, 2018

Landed in be2cbcc

@kfarnung kfarnung deleted the perf_buffers branch January 25, 2018 01:54
@kfarnung kfarnung mentioned this pull request Jan 25, 2018
Closed
2 tasks
@kfarnung
Copy link
Contributor Author

kfarnung commented Jan 25, 2018

I created a backport PR #18364

kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Jan 25, 2018
@kfarnung
http2,perf_hooks: perf state using AliasedBuffer
ce15647 
Update performance_state to use AliasedBuffer and update usage sites.

PR-URL: nodejs/node#18300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Jan 25, 2018
@kfarnung
perf_hooks: perf state using AliasedBuffer
11035cf 
Update performance_state to use AliasedBuffer and update usage sites.

PR-URL: nodejs/node#18300
Backport-PR-URL: nodejs#453
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mike Kaufman <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@kfarnung @evanlucas
http2,perf_hooks: perf state using AliasedBuffer
39612a8 
Update performance_state to use AliasedBuffer and update usage sites.

PR-URL: #18300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
kfarnung added a commit to kfarnung/node that referenced this pull request Feb 2, 2018
@kfarnung
http2,perf_hooks: perf state using AliasedBuffer
29ba51d 
Update performance_state to use AliasedBuffer and update usage sites.

PR-URL: nodejs#18300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018
gibfahn pushed a commit that referenced this pull request Feb 19, 2018
@kfarnung @gibfahn
http2,perf_hooks: perf state using AliasedBuffer
dea44b9 
Update performance_state to use AliasedBuffer and update usage sites.

PR-URL: #18300
Backport-PR-URL: #18364
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@kfarnung @kjin
http2,perf_hooks: perf state using AliasedBuffer
7767aaa 
This is the portion of be2cbcc that is not in dea44b9.

Update performance_state to use AliasedBuffer and update usage sites.

PR-URL: nodejs#18300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@kfarnung @MylesBorins
http2,perf_hooks: perf state using AliasedBuffer
9a4bac2 
This is the portion of be2cbcc that is not in dea44b9.

Update performance_state to use AliasedBuffer and update usage sites.

Backport-PR-URL: #20456
PR-URL: #18300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@kfarnung @MayaLekova
http2,perf_hooks: perf state using AliasedBuffer
9904a24 
Update performance_state to use AliasedBuffer and update usage sites.

PR-URL: nodejs#18300
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

+1 more reviewer

@mike-kaufman mike-kaufman mike-kaufman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kfarnung kfarnung

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kfarnung @jasnell @addaleax @mike-kaufman @MylesBorins @gibfahn @nodejs-github-bot