Add coverage generation files from nodejs/testing #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs/testing#37 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Add patch files that enable coverage generation for Node core as well as a simple script for rendering a table of nightly coverage results. Ref: nodejs/testing#36 PR-URL: nodejs/testing#38 Reviewed-By: Michael Dawson <[email protected]>
Adjust the generation of the summary web page for the coverage data to fit the nodejs.org look and feel. PR-URL: nodejs/testing#39 Reviewed-By: Anna Henningsen <[email protected]>
Now that we have the --coverage option landed in core we can remove some of the patches for node.gyp PR-URL: nodejs/testing#40 Reviewed-By: Anna Henningsen <[email protected]>
- fixing copyright symbols - changing styling and formatting for page - using monospace font for sha PR-URL: nodejs/testing#41 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
The presented times may be confusing when displayed without time zone information. PR-URL: nodejs/testing#42 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ryan Lewis <[email protected]>
Scripts needed for coverage job now come from the testing repo. Update README.md to reflect that. PR-URL: nodejs/testing#44 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs/testing#51 Reviewed-By: Michael Dawson <[email protected]>
- new targets have been added to the node Makefile - update descriptions to reflect that CI job now - uses those targets PR-URL: nodejs/testing#52 Reviewed-By: Santiago Gimeno <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
maclover7
added a commit
that referenced
this pull request
Jan 4, 2018
PR-URL: #1055 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Fixes: nodejs/testing#56
Trott
pushed a commit
to nodejs/testing
that referenced
this pull request
Jan 4, 2018
Files have moved to nodejs/build repository. Refs: nodejs/build#1055 Fixes: #56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to copy over original Git history, so that way there's a papertrail.
Will update Jenkins once this lands.
cc @addaleax (primary author) @cjihrig @Trott