-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade urllib3 from 1.26.20 to 2.6.0 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192442 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192443
Summary of ChangesHello @nn6n, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's security posture by updating a critical dependency. Automatically generated by Snyk, it specifically targets and resolves two known vulnerabilities associated with the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk aims to upgrade urllib3 to fix security vulnerabilities. However, the proposed change to version 2.6.0 introduces a critical dependency conflict with requests==2.25.1, which requires urllib3<1.27. This will break the installation of test dependencies for Python 3.12. Additionally, this security fix has only been applied to the requirements file for Python 3.12, leaving other environments (for Python 3.8, 3.9, 3.10, and 3.11) potentially vulnerable as they use the same version of requests. The dependency conflict needs to be resolved, and the fix should be applied consistently across all relevant requirement files.
| requests==2.25.1 | ||
| pytest==7.4.4 | ||
| narwhals>=1.15.1 | ||
| urllib3>=2.6.0 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a dependency conflict. The requests==2.25.1 package specified on line 1 has a requirement for urllib3<1.27. This line adds a conflicting requirement of urllib3>=2.6.0, which will cause dependency resolution to fail.
To resolve this, you could either:
- Upgrade
requeststo a version compatible withurllib3v2.x (e.g.,requests>=2.30.0). This would likely need to be done for allrequirements*.txtfiles. - Pin
urllib3to a secure version from the 1.x branch that is compatible withrequests==2.25.1. For example,urllib3==1.26.18is the latest in the 1.x series and contains security fixes.
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
test_requirements/requirements_312_core.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling