Skip to content

Conversation

@nn6n
Copy link
Owner

@nn6n nn6n commented Dec 7, 2025

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • test_requirements/requirements_39_core.txt
⚠️ Warning
equests 2.25.1 requires urllib3, which is not installed.

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @nn6n, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the urllib3 package. The update addresses two specific vulnerabilities by pinning urllib3 to version 2.6.0 within the test requirements, thereby mitigating potential risks associated with older, vulnerable versions of the library.

Highlights

  • Security Upgrade: This pull request upgrades the urllib3 package from version 1.26.20 to 2.6.0 to address two identified security vulnerabilities (SNYK-PYTHON-URLLIB3-14192442 and SNYK-PYTHON-URLLIB3-14192443).
  • Dependency Pinning: The urllib3 dependency is now explicitly pinned to version 2.6.0 in test_requirements/requirements_39_core.txt, even though it was not a direct requirement, to ensure the secure version is used.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request from Snyk aims to fix security vulnerabilities by upgrading urllib3. However, the proposed upgrade to urllib3>=2.6.0 is incompatible with the currently pinned requests==2.25.1, which requires urllib3<1.27. This will break the dependency installation. To fix this, requests needs to be upgraded to a version compatible with urllib3 v2, such as requests>=2.30.0.

Additionally, this change is only applied to the requirements for Python 3.9. The same vulnerability and dependency issue likely exist for other Python versions (3.8, 3.10, 3.11, 3.12) defined in other test_requirements files, and they should be fixed consistently across all environments.

requests==2.25.1
pytest==6.2.3
narwhals>=1.15.1
urllib3>=2.6.0 # not directly required, pinned by Snyk to avoid a vulnerability

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to urllib3>=2.6.0 introduces a dependency conflict. The requests package, pinned to requests==2.25.1 on line 1, has a dependency on urllib3<1.27. The new version 2.6.0 does not satisfy this constraint, which will cause dependency resolution to fail during installation.

To resolve this, the requests package must be upgraded to a version that is compatible with urllib3 v2.x, such as requests>=2.30.0. You will need to manually update the requests pin in this file to a more recent version, for example requests==2.31.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants