fix: improve error when exiting before running Nitric.run() #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also logs when the program exits without starting the nitric app
tjholm
reviewed
Aug 9, 2024
| if not Nitric.has_run(): | ||
| print( | ||
| "WARNING: The Nitric application was not started. " | ||
| "If you intended to start the application, call Nitric.run() before exiting." |
Member
There was a problem hiding this comment.
"before exiting" reads a bit strange here, it technically makes sense. Not sure if its better phrasing but maybe something like "at the end of your application?".
tjholm
approved these changes
Aug 15, 2024
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.