Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable31] fix(bidi): adjust UI to RTL support #14235

Merged
merged 9 commits into from
Jan 28, 2025
4 changes: 2 additions & 2 deletions src/PublicShareAuthSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ body .modal-wrapper * {
height: 100%;

background: var(--color-main-background);
border-left: 1px solid var(--color-border);
border-inline-start: 1px solid var(--color-border);

overflow-x: hidden;
overflow-y: auto;
Expand All @@ -246,7 +246,7 @@ body .modal-wrapper * {
justify-content: center;

/* Unset conflicting rules from guest.css for the sidebar. */
text-align: left;
text-align: start;

& > .emptycontent {
/* Remove default margin-top as it is unneeded when showing only the empty
Expand Down
15 changes: 1 addition & 14 deletions src/PublicShareSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ footer {
width: clamp(300px, 27vw, 500px);

background: var(--color-main-background);
border-left: 1px solid var(--color-border);
border-inline-start: 1px solid var(--color-border);

overflow-x: hidden;
overflow-y: auto;
Expand All @@ -304,19 +304,6 @@ footer {
margin-top: 0;
}

#talk-sidebar .emptycontent button .icon {
/* Override rules set for the main icon of an empty content area when an
* icon is shown in a button. */
background-size: unset;
width: unset;
height: unset;
margin: unset;

/* Frame the loading icon on the right border of the button. */
top: -3px;
right: -5px;
}

#talk-sidebar .call-button {
margin: calc(var(--default-grid-baseline) * 2) auto;
}
Expand Down
2 changes: 1 addition & 1 deletion src/PublicShareSidebarTrigger.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ const ariaLabel = computed(() => {

<style scoped>
#talk-sidebar-trigger {
margin-left: var(--default-grid-baseline);
margin-inline-start: var(--default-grid-baseline);
}
</style>
3 changes: 3 additions & 0 deletions src/assets/markdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

ul,
ol {
/* stylelint-disable-next-line csstools/use-logical */
padding-left: 0;
padding-inline-start: 15px;

Expand Down Expand Up @@ -54,8 +55,10 @@
}

blockquote {
/* stylelint-disable-next-line csstools/use-logical */
padding-left: 0;
padding-inline-start: 13px;
/* stylelint-disable-next-line csstools/use-logical */
border-left: none;
border-inline-start: 4px solid var(--color-border);
}
Expand Down
11 changes: 5 additions & 6 deletions src/components/AvatarWrapper/AvatarWrapper.vue
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export default {
}

&.bot {
padding-left: 5px;
padding-inline-start: 5px;
background-color: var(--color-background-darker);
}

Expand All @@ -250,15 +250,14 @@ export default {
padding: 0;
display: block;
text-align: center;
margin-left: auto;
margin-right: auto;
margin-inline: auto;
}
}

&--condensed {
width: unset;
height: unset;
margin-left: calc(var(--condensed-overlap) * -1px);
margin-inline-start: calc(var(--condensed-overlap) * -1px);
display: flex;

& > .icon,
Expand All @@ -282,7 +281,7 @@ export default {

&__user-status {
position: absolute;
right: -4px;
inset-inline-end: -4px;
bottom: -4px;
height: 18px;
width: 18px;
Expand All @@ -295,7 +294,7 @@ export default {
.loading-avatar {
position: absolute;
top: 0;
left: 0;
inset-inline-start: 0;
width: 100%;
height: 100%;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -366,18 +366,13 @@ export default {
}
}

// TODO: upstream collapse icon position fix
:deep(.icon-collapse) {
position: absolute !important;
left: 0;
}

// Warning dialog when deleting breakout rooms
:deep(.dialog) {
padding-block: 0px 8px;
padding-inline: 12px 8px;
}

.delete {
margin-right: auto;
margin-inline-end: auto;
}
</style>
4 changes: 2 additions & 2 deletions src/components/BreakoutRoomsEditor/SelectableParticipant.vue
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export default {
&__checkbox {
position: absolute;
top: 0;
left: 0;
inset-inline-start: 0;
z-index: -1;
opacity: 0;
}
Expand All @@ -220,7 +220,7 @@ export default {

&__check-icon {
display: none;
margin-left: auto;
margin-inline-start: auto;
width: var(--default-clickable-area);
flex-shrink: 0;
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/CallView/CallView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@ export default {

<style lang="scss" scoped>
@import '../../assets/variables';

/* stylelint-disable csstools/use-logical */
#call-container {
width: 100%;
height: 100%;
Expand Down
1 change: 1 addition & 0 deletions src/components/CallView/Grid/Grid.vue
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,7 @@ export default {
</script>

<style lang="scss" scoped>
/* stylelint-disable csstools/use-logical */
.grid-main-wrapper {
--navigation-position: calc(var(--default-grid-baseline) * 2);
position: relative;
Expand Down
1 change: 1 addition & 0 deletions src/components/CallView/shared/LocalVideo.vue
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ export default {
</script>

<style lang="scss" scoped>
/* stylelint-disable csstools/use-logical */
.not-connected {
video,
.avatar-container {
Expand Down
1 change: 1 addition & 0 deletions src/components/CallView/shared/PresenterOverlay.vue
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ export default {
</script>

<style lang="scss" scoped>
/* stylelint-disable csstools/use-logical */
.presenter-overlay {
position: absolute;
top: 0;
Expand Down
1 change: 1 addition & 0 deletions src/components/CallView/shared/ReactionToaster.vue
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ export default {
</script>

<style lang="scss" scoped>
/* stylelint-disable csstools/use-logical */
.toaster {
position: absolute;
bottom: 20px;
Expand Down
2 changes: 1 addition & 1 deletion src/components/CallView/shared/Screen.vue
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export default {
</script>

<style lang="scss" scoped>

/* stylelint-disable csstools/use-logical */
.screenContainer {
width: 100%;
height: 100%;
Expand Down
1 change: 1 addition & 0 deletions src/components/CallView/shared/VideoBackground.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export default {
</script>

<style lang="scss" scoped>
/* stylelint-disable csstools/use-logical */
.video-background {
position: absolute;
left: 0;
Expand Down
5 changes: 3 additions & 2 deletions src/components/CallView/shared/VideoBottomBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ export default {
}

& .participant-name {
margin-right: 0;
margin-inline-end: 0;
}
}
}
Expand Down Expand Up @@ -346,7 +346,8 @@ export default {

.participant-name {
color: white;
margin: 0 auto 0 8px;
margin-block: 0px;
margin-inline: 8px auto;
position: relative;
white-space: nowrap;
overflow: hidden;
Expand Down
1 change: 1 addition & 0 deletions src/components/CallView/shared/VideoVue.vue
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,7 @@ export default {
</script>

<style lang="scss" scoped>
/* stylelint-disable csstools/use-logical */
.not-connected {
video,
.avatar-container {
Expand Down
1 change: 1 addition & 0 deletions src/components/CallView/shared/ViewerOverlayCallView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ export default {
</script>

<style lang="scss" scoped>
/* stylelint-disable csstools/use-logical */
.viewer-overlay-ghost {
position: absolute;
bottom: 8px;
Expand Down
7 changes: 2 additions & 5 deletions src/components/ChatView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,7 @@ export default {

.dragover {
position: absolute;
top: 10%;
left: 10%;
width: 80%;
height: 80%;
inset: 10%;
background: var(--color-primary-element-light);
z-index: 11;
display: flex;
Expand All @@ -247,7 +244,7 @@ export default {
&__button {
position: absolute !important;
bottom: 8px;
right: 24px;
inset-inline-end: 24px;
z-index: 2;
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/ConversationIcon.vue
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ export default {

&__type {
position: absolute;
right: -2px;
inset-inline-end: -2px;
bottom: -2px;
display: flex;
align-content: center;
Expand All @@ -279,7 +279,7 @@ export default {
.overlap-icon {
position: absolute;
top: 0;
left: calc(var(--icon-size) - 12px);
inset-inline-start: calc(var(--icon-size) - 12px);
line-height: 100%;
display: inline-block;
vertical-align: middle;
Expand Down
2 changes: 1 addition & 1 deletion src/components/ConversationSettings/BotsSettings.vue
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export default {
display: flex;
justify-content: center;
align-items: center;
margin-left: auto;
margin-inline-start: auto;
}

&-button {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@

<!-- Edit advanced permissions -->
<NcButton v-show="showEditButton"
class="edit-button"
type="tertiary"
:aria-label="t('spreed', 'Edit permissions')"
@click="showPermissionsEditor = true">
Expand Down Expand Up @@ -248,15 +249,14 @@ export default {
&--advanced {
display: flex;
justify-content: flex-start;

// Edit button
button {
margin-left: 16px;
}
}
}
}

.edit-button {
margin-inline-start: 16px;
}

.conversation-permissions-editor__hint {
color: var(--color-text-maxcontrast);
margin-bottom: 16px;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -311,18 +311,6 @@ export default {
</script>

<style lang="scss" scoped>
:deep(button.icon) {
height: 32px;
width: 32px;
display: inline-block;
margin-left: 5px;
vertical-align: middle;
}

:deep(.modal-container) {
display: flex !important;
}

:deep(.app-settings-section__hint) {
color: var(--color-text-maxcontrast);
padding: 8px 0;
Expand All @@ -335,11 +323,7 @@ export default {
margin: calc(var(--default-grid-baseline) * 4) 0 var(--default-grid-baseline) 0;
}

:deep(.app-settings-subsection) {
:deep(.app-settings-subsection:not(:first-child)) {
margin-top: 25px;

&:first-child {
margin-top: 0;
}
}
</style>
Loading
Loading