fix(ocp): Deprecate isInstalled and add isEnabledForAnyone instead

The method name was really confusing

Signed-off-by: Côme Chilliet <[email protected]>

lib/private/App/AppManager.php

@@ -393,10 +393,12 @@ private function checkAppForGroups(string $enabled, IGroup $group): bool {
 	 * Notice: This actually checks if the app is enabled and not only if it is installed.
 	 *
 	 * @param string $appId
-	 * @param IGroup[]|String[] $groups
-	 * @return bool
 	 */
-	public function isInstalled($appId) {
+	public function isInstalled($appId): bool {
+		return $this->isEnabledForAnyone($appId);
+	}
+
+	public function isEnabledForAnyone(string $appId): bool {
 		$installedApps = $this->getInstalledAppsValues();
 		return isset($installedApps[$appId]);
 	}

lib/public/App/IAppManager.php

@@ -79,9 +79,17 @@ public function isEnabledForUser($appId, $user = null);
 	 * @param string $appId
 	 * @return bool
 	 * @since 8.0.0
+	 * @deprecated 31.0.0 Use either {@see self::isEnabledForUser} or {@see self::isEnabledForAnyone}
 	 */
 	public function isInstalled($appId);
 
+	/**
+	 * Check if an app is enabled in the instance, either for everyone or for specific groups
+	 *
+	 * @since 31.0.0
+	 */
+	public function isEnabledForAnyone(string $appId): bool;
+
 	/**
 	 * Check if an app should be enabled by default
 	 *