-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(application_settings) : Revamp application apm settings to sync with the latest features/functionalities in apm settings in ui #2799
Open
vinay-newrelic
wants to merge
16
commits into
main
Choose a base branch
from
NR-355739
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+741
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the latest features
…with the latest features/functionalities in apm settings in ui
…with the latest features/functionalities in apm settings in ui
…with the latest features/functionalities in apm settings in ui
…with the latest features/functionalities in apm settings in ui
… latest released/available features/functionalities in apm settings ui
… latest released/available features/functionalities in apm settings ui
… to sync with the latest released/available features/functionalities in apm settings ui
… to sync with the latest released/available features/functionalities in apm settings ui
… to sync with the latest released/available features/functionalities in apm settings ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this TF resource only supports a subset of the application settings available on the APM UI .
This PR concludes the changes required for
newrelic_application_settings
resource to add the missing set of configuration settings that are available on the UIBreaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
My commit message follows conventional commits
My code is formatted to Go standards
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.