Fixed aggregations when group by and having conditions are used #284
+93
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Related: #283 |
Contributor
Author
|
We would need this also in 3.0 and 2.4 branches (old project we do not have time to upgrade yet). Should I prepare separate PRs or will you just apply this changes to older branches too? |
90aca4d to
db816ef
Compare
db816ef to
06702e6
Compare
Member
|
You don't have to. I'll backport it myself. |
dg
pushed a commit
that referenced
this pull request
Nov 8, 2021
dg
pushed a commit
that referenced
this pull request
Nov 8, 2021
Contributor
Author
Thanks |
dg
pushed a commit
that referenced
this pull request
Nov 24, 2021
dg
pushed a commit
that referenced
this pull request
Dec 13, 2023
dg
pushed a commit
that referenced
this pull request
Dec 13, 2023
dg
pushed a commit
that referenced
this pull request
Dec 13, 2023
dg
pushed a commit
that referenced
this pull request
Dec 13, 2023
dg
pushed a commit
that referenced
this pull request
Dec 13, 2023
dg
pushed a commit
that referenced
this pull request
Dec 13, 2023
dg
pushed a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes wrong results of aggregate functions applied on selection with group and having conditions. Previously aggregate of all rows even that not matching having conditions were returned.