-
Notifications
You must be signed in to change notification settings - Fork 1
Backport MEME Comment #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Match MEME
Rather than show complex "DELETED" for every prompt in a comment type because there may be many.
…when updating comment status.
…t` to TCommentCollection
# Conflicts: # app/view/netcreate/components/NCEdgeTable.jsx # app/view/netcreate/components/NCNodeTable.jsx
… have not been defined.
…s implementation in MEME)
…s updated when Node selection is switched
…to use URCommentVBtn (and URCommentCollectionMgr)
…ment.id` to match pmcData
…for URCommentCollectionMgr calls.
…d directly by URCommentVBtn but we might want to restore this to force close the currently open comment window and re-open the table comment button
…l components. Simplify URDATA handlers." "SELECTION" and "HILITE" are not yet implemented.
…te, then dc-comments.DEFAULT_CommentTypes then fall back to DEFAULT_COMMENTTYPE #244
…y defaults defined in dc-comments
|
@jdanish Please QA the comment system. The MEME comment system should work like NC's with the addition of being able to set comment types via the project template file. |
|
OK! Do you want me to post issues or comments here if I find things? Also, are the notifications part of the update? I noticed an error there earlier ... Thanks! |
|
Thanks! A new issue would be helpful for tracking. Otherwise we end up with a hodge podge of comments and replies. |
|
OK, added #321 Will you see these if assigned or do they need to be in project too? |

This does two main things:
ac-commentanddc-commentshould be basically equivalantURComment*components should be basically equivalent with the conversion of UNISYS callsURCommentThreadMgrhas been replaced byURCommentCollectionMgrand all buttons are now managed viaURCommentStatuscomment-mgrshould have a similar API, with mostly database calls unique to each system.NCNodeTableandNCEdgeTablehave been refactored to be simpler functional components.Wiki Update
(To be added to wiki with the PR)
Comment Templates
Defining Comment Types in the Project Template file
Comment types can be defined in the project's
*.template.tomlfile.Cascading Comment Types
*.template.tomlis used as the default comment type._default.template.toml. You can edit that file to have new projects automatically use the comment types defined in_default.template.toml.*.template.tomlfile, the system will first try to use the types definedDEFAULT_CommentTypesindc-comments. This allows you to assign a standard set of comments if you're comfortable code diving, but is not intended for regular use.DEFAULT_CommentTypesis not defined indc-comments, the system will fall back to a single generic template. This ensures that there is ALWAYS a usable comment type even if the project anddc-commentsare not defined:Valid Slugs
Currently (as of 1/6/2025), known
CTypeslugs are:...but you can also use any other string for a custom comment.
NOTES
template.toml. You need to edit these by hand.