automatically add the visual studio compiler folder to the environment path #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In some case
gsplat
needs to compile cuda/c++ code on the fly (just-in-time compilation),to handle different number of color channels for example, like done in the test
test_rasterize_to_pixels
when using channels=128.In that case
cl.exe
needs to be on the path when on windows in order for pytorch to be able to do the compilation.One can follow the step documented here
but that requires a manual step each time time one wants to use gsplat, which very unconvenient.
Solution:
We can instead add the folder automatically to the path at runtime using a mechanism used in
CuPy
here to discover the folder that contains the cl.exe file.Ideally this mechanism would be implemented in pytorch, but that may take a while to be completed. We can implement it in
gsplat
in the mean time.