Skip to content
This repository was archived by the owner on Mar 18, 2025. It is now read-only.

Fix PreserveText preg_split with $limit null#2

Merged
mraspe merged 1 commit intomraspe:developfrom
glady:patch-1
Oct 14, 2022
Merged

Fix PreserveText preg_split with $limit null#2
mraspe merged 1 commit intomraspe:developfrom
glady:patch-1

Conversation

@glady
Copy link
Collaborator

@glady glady commented Oct 13, 2022

Description

Deprecated in PHP 8.1

  • preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

Deprecated in PHP 8.1
- preg_split(): Passing null to parameter mraspe#3 ($limit) of type int is deprecated
- -1 and 0 had same effect in versions before
@glady
Copy link
Collaborator Author

glady commented Oct 13, 2022

Hint: original repository also set -1 here.

@mraspe mraspe merged commit 451787c into mraspe:develop Oct 14, 2022
glady pushed a commit to glady/PHPWord that referenced this pull request Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants