Asciidoc: Don't split in attributes include:: and ifeval:: lines#298
Merged
mquinson merged 1 commit intomquinson:masterfrom Mar 13, 2021
Merged
Asciidoc: Don't split in attributes include:: and ifeval:: lines#298mquinson merged 1 commit intomquinson:masterfrom
mquinson merged 1 commit intomquinson:masterfrom
Conversation
Owner
|
Hello Danilo, I did check your changes, and they look very good, many thanks! The only nitpicking remark could be that the the test could have been placed in another test. But I agree that what you needed to add was so small that it didn't really deserve a separate test. Thanks for this contribution, and welcome onboard ;) |
Contributor
Author
|
@mquinson thanks for the feedback and quick reviewing. |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 14, 2021
Don't split in attributes include:: and ifeval:: lines. This fix an issue in the new FreeBSD translation workflow. Obtained from: mquinson/po4a#298 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@568387 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 14, 2021
Don't split in attributes include:: and ifeval:: lines. This fix an issue in the new FreeBSD translation workflow. Obtained from: mquinson/po4a#298
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Mar 15, 2021
Don't split in attributes include:: and ifeval:: lines. This fix an issue in the new FreeBSD translation workflow. Obtained from: mquinson/po4a#298 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@568387 35697150-7ecd-e111-bb59-0022644237b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue summary:
More details in the maillist post.
First PR here, I'll need someone to review please.
Thanks!