Skip to content

Fix ActionNode keep resetting to equal#9

Merged
atomic-junky merged 1 commit into
monologue-tool:mainfrom
Jeremi360:Fix-ActionNode-keep-reseting-to-equal
Aug 6, 2024
Merged

Fix ActionNode keep resetting to equal#9
atomic-junky merged 1 commit into
monologue-tool:mainfrom
Jeremi360:Fix-ActionNode-keep-reseting-to-equal

Conversation

@Jeremi360

@Jeremi360 Jeremi360 commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

This fix issuie:

  1. Crate Int variable in RootNode
  2. Crate ActionNode
  3. Set ActionNode mode to VariableAction
  4. Set Int to be modfied Variable
  5. Try to set operator to anytihng other than =
  6. Exit SidePanel of this ActionNode
  7. Try Edit ActionNode - you will notice that operator resest back to =

Also if you load json with ActionNode/VariableAction all operators will be rested to =

Summary by Sourcery

Fix the issue where the operator in ActionNode resets to '=' upon exiting and re-editing the SidePanel, and ensure that loading JSON with ActionNode/VariableAction retains the correct operator.

Bug Fixes:

  • Fix issue where the operator in ActionNode resets to '=' when exiting and re-editing the SidePanel.
  • Ensure that loading JSON with ActionNode/VariableAction retains the correct operator instead of resetting to '='.

@sourcery-ai

sourcery-ai Bot commented Aug 6, 2024

Copy link
Copy Markdown

Reviewer's Guide by Sourcery

This pull request addresses an issue where the operator in an ActionNode would reset to '=' when exiting and re-entering the side panel or loading from JSON. The fix involves updating the ActionNodePanel.gd script to correctly set the operator dropdown based on the 'Operator' property from the action dictionary.

File-Level Changes

Files Changes
Scripts/SidePanelNodes/ActionNodePanel.gd Implemented a fix to ensure the operator dropdown in ActionNodePanel correctly reflects the 'Operator' property from the action dictionary, preventing it from resetting to '='.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jeremi360 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting the operator setting logic into a separate function for better readability and maintainability.
  • Please review and correct the typos in the pull request description to maintain overall project quality.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@monologue-tool monologue-tool deleted a comment from sourcery-ai Bot Aug 6, 2024
@atomic-junky atomic-junky merged commit 54a5976 into monologue-tool:main Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants