Ui redesign#47
Merged
Merged
Conversation
Sorry :(
For the PopupMenu corner
There was a problem hiding this comment.
The pull request #47 has too many files changed.
We can only review pull requests with up to 300 changed files, and this pull request has 516.
Closed
RailKill
approved these changes
Nov 25, 2024
RailKill
left a comment
Collaborator
There was a problem hiding this comment.
Looks really good! Some bugs I found and fixed:
- could not switch tabs or close the welcome window after "+" was selected
- when switching tabs with the side panel open, the fields will be added to the side panel without clearing the previous one (due to deselect event not happening during tab-switching)
- words can somehow spill out of MonologueText, fixed using "clip contents"
Excellent work! I think you've pretty much covered all the UI for the features that we want to add. This should be ready to merge.
Collaborator
Author
|
Thanks a lot for all these fixes! I'm glad you like these changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has been around for a while but I think the new interface is pretty clean now. There are probably still a few changes to be made but I think we've got a pretty solid base.
We've still got the reorderable lists on the feature/reorderable-list branch, but they need more complex changes to the code, and that's not urgent.
As for the title bar, we'll have to wait for the feature to arrive on the Godot side (it's pretty buggy at the moment) but we'll do that later.