Prevent group delete at the same time as select or when panel is up#22
Merged
Conversation
Reviewer's Guide by SourceryThis pull request addresses a bug introduced in a previous commit (#19) that allowed users to delete nodes with the 'Delete' key while the panel is open, causing crashes. The changes prevent node deletion when the side panel is visible or when a node is being actively edited. Additionally, it fixes a crash that occurred when selecting and deleting a node within a 0.1-second window. File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @RailKill - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was introduced by me in #19, it allowed the user to delete nodes with the
Deletekey while the panel is open. This causes crashes because the node is no longer there while editing properties, as theDeletekey is used in text-editing as well, but will delete the node at the same time. There was also a funny way to crash the program by selecting the node and deleting it within await 0.1 seconds, so the node is no longer there when the panel wants to open.This PR fixes the 0.1 second crash window, and prevent crashes associated with triggering the Delete hotkey while panel is open. You can still delete nodes with the 'X' button while the panel is open, this works fine and doesn't crash the program, the problem is with the delete timing with the
Deletekey.Summary by Sourcery
Prevent node deletion when the side panel is open or when a node is selected and deleted within a short time frame to fix crashes.
Bug Fixes: