Fix expired session login dialog #16806
Open
+12
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Maps the login window action "Security/Login" to the controller one "security/login" (lowercase).
Additionally, some minor css changes were made to the status message toast, as its content was being clipped with short messages (such as that which is shown after successfully extending a session).
Why is it needed?
Login is probably the only action where it can occur both directly via the controller (main login page) and via a window (extend session). The window, however, must use the newer (3.x) casing scheme in its action to call its corresponding processor. The core connector, however, was only testing for the presence of the lowercase formatted action to make certain decisions.
How to test
session_cookie_lifetimesystem setting to a very low number like 60 (1 minute) and login with the remember me checkbox ticked; or 2) manually delete the session cookie from your browser's dev tools pane.Related issue(s)/PR(s)
Resolves #16742
Special Note
The process of fixing the underlying cause of this issue raises another, which will be separately addressed. Some requests, like when trying to save a Resource after your session has expired, result in a mangle 401 response which prevents the login window from ever showing.