Skip to content

Conversation

@smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Jan 21, 2025

What does it do?

Identifies and fixes a problem present in the getPropertySet method where the Element name is re-set, but without the necessary colon between the actual Element name and the rest of its tag.

Why It's Needed / How to Test

See PR #16322

Note

This is by and large the result of @Mark-H's work -- although it did take the better part of a night to track down the issue he was asking for help on ;-)

Fixes issue with default value not working when prop set is specified in an Element call
Fix code quality issue
@Mark-H
Copy link
Collaborator

Mark-H commented Jan 24, 2025

Thanks for taking over the PR and working on it some more. It is indeed something that takes a while to figure out - it took me like 3 days of work to get to that PR which fixed some issues, but left the one I couldn't sort out.

I've added a note to my to do list to review and dig back into this to give it a proper review. It may take me a few weeks but is on the list.

@opengeek opengeek added this to the v3.2.0 milestone Mar 21, 2025
@jaygilmore
Copy link
Member

jaygilmore commented May 15, 2025

It may take me a few weeks but is on the list.

Hey @Mark-H any chance you might be able to take another peek at this one, since you were the OP? :)

@smg6511
Copy link
Collaborator Author

smg6511 commented Jul 13, 2025

@Mark-H - It's been a few few weeks (just giving you a hard time). It'd be great to get all that work that mainly you did implemented ;-) ... can you carve out some time to check this soon?

@smg6511
Copy link
Collaborator Author

smg6511 commented Nov 19, 2025

@Mark-H - Hey, I see you've been a little more active lately, so giving another bump on this one ;-)

@smg6511
Copy link
Collaborator Author

smg6511 commented Dec 10, 2025

@opengeek - Hey, I've bumped Mark a few times on this, but it seems he's got too much going on. I think this would be in your wheelhouse to review though ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants