Reorganize config #46

pan-x-c · 2025-05-21T13:23:07Z

Description

Renamed Fields

config.monitor.project/name -> config.project/name
config.global_config.batch_size/total_epochs -> config.buffer.batch_size/total_epochs
config.global_config.eval_interval/eval_on_latest_ckpt -> config.explorer.eval_interval/eval_on_latest_checkpoint
config.global_config.algorithm_type -> config.algorithm.algorithm_type
config.model.checkpoint_path -> config.checkpoint_root_dir
config.model.enable_thinking -> config.explorer.rollout_model.enable_thinking
config.explorer.engine_num/engine_type/tensor_parallel_size/... -> config.explorer.rollout_models.engine_num/engine_type/tensor_parallel_size/...
config.trainer.get_exp_strategy -> config.buffer.trainer_input.read_experience_strategy
config.trainer.sft_warmup_steps -> config.buffer.trainer_input.sft_warmup_steps
config.buffer.explorer_input.taskset.rollout_args.repeat_times -> config.buffer.explorer_input.taskset.rollout_args.n

Removed Fields

config.global_config
config.explorer.backend/use_ray/max_pending_requests/max_waiting_steps
monitor.cache_root_dir

Added Fields

config.algorithm.repeat_times/gamma/lam
config.explorer.rollout_model
config.trainer.actor_use_kl_loss/actor_kl_loss_coef/actor_entropy_coeff/actor_grad_clip/actor_clip_ratio

Fixed bugs

config_manager.py not found when using trinity studio

Checklist

Please check the following items before code is ready to be reviewed.

Code has passed all tests
Docstrings have been added/updated in Google Style
Documentation has been updated
Code is ready for review

docs/sphinx_doc/source/tutorial/trinity_configs.md

pan-x-c · 2025-05-22T05:51:08Z

/run-unittest

github-actions · 2025-05-22T06:02:16Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
23	23	0	0	0	0	0	631ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name	Status	Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer	✅	4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer	✅	1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅	1ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅	1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate	✅	45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate	✅	42ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate	✅	51ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate	✅	53ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate	✅	40ms
tests/common/vllm_test.py::TestAPIServer::test_api	✅	22ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask	✅	1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer	✅	1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	107ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	21ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool	✅	19ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer	✅	1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer	✅	215ms

Github Test Reporter by CTRF 💚

docs/sphinx_doc/source/tutorial/trinity_configs.md

examples/dpo_humanlike/dpo.yaml

pan-x-c · 2025-05-22T07:10:00Z

/run-unittest

github-actions · 2025-05-22T07:23:00Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
23	23	0	0	0	0	0	743ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name	Status	Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer	✅	4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer	✅	1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅	1ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅	5ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅	1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate	✅	45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate	✅	43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate	✅	52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate	✅	53ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate	✅	39ms
tests/common/vllm_test.py::TestAPIServer::test_api	✅	21ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask	✅	1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer	✅	1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	127ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	22ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool	✅	19ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer	✅	1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer	✅	301ms

Github Test Reporter by CTRF 💚

docs/sphinx_doc/source/tutorial/trinity_configs.md

examples/grpo_gsm8k/gsm8k.yaml

examples/async_gsm8k/explorer.yaml

pan-x-c · 2025-05-22T10:02:42Z

/run-unittest

docs/sphinx_doc/source/tutorial/example_reasoning_basic.md

github-actions · 2025-05-22T10:17:07Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
23	23	0	0	0	0	0	828ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name	Status	Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer	✅	4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer	✅	1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅	1ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅	6ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅	1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate	✅	45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate	✅	43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate	✅	52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate	✅	51ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate	✅	38ms
tests/common/vllm_test.py::TestAPIServer::test_api	✅	22ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask	✅	1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer	✅	1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	132ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	121ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool	✅	19ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer	✅	1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer	✅	282ms

Github Test Reporter by CTRF 💚

pan-x-c added 4 commits May 21, 2025 20:04

refactor global config

a04ca48

update config files

1362f35

fix vllm test

dffa7c2

fix explorer tests

3650c25

hiyuchang reviewed May 22, 2025

View reviewed changes

docs/sphinx_doc/source/tutorial/trinity_configs.md Outdated Show resolved Hide resolved

fix trainer tests

84efe6b

hiyuchang reviewed May 22, 2025

View reviewed changes

docs/sphinx_doc/source/tutorial/trinity_configs.md Outdated Show resolved Hide resolved

pan-x-c added 2 commits May 22, 2025 12:19

add algorithm type

5d8b6d0

fix some comments

b8289ad

xieyxclack reviewed May 22, 2025

View reviewed changes

docs/sphinx_doc/source/tutorial/trinity_configs.md Show resolved Hide resolved

hiyuchang reviewed May 22, 2025

View reviewed changes

examples/dpo_humanlike/dpo.yaml Outdated Show resolved Hide resolved

pan-x-c added 4 commits May 22, 2025 14:30

fix comments

a20efa4

fix comments

466e469

update doc stringh

0f66258

update comments

07e1923

fix dpo config

92474a1

hiyuchang reviewed May 22, 2025

View reviewed changes

docs/sphinx_doc/source/tutorial/trinity_configs.md Show resolved Hide resolved

hiyuchang reviewed May 22, 2025

View reviewed changes

examples/grpo_gsm8k/gsm8k.yaml Show resolved Hide resolved

pan-x-c added 5 commits May 22, 2025 15:46

fix gpu calculating for train mode

4a71cc7

fix monitor name

881383a

fix reset method

53731dd

add tests for workflow reset

23524bd

remove used fields

01bc491

hiyuchang reviewed May 22, 2025

View reviewed changes

examples/async_gsm8k/explorer.yaml Outdated Show resolved Hide resolved

pan-x-c added 2 commits May 22, 2025 16:50

fix config name

bfc78e5

update sft log

0fc4151

pan-x-c added 2 commits May 22, 2025 17:48

update sft log

684bcba

fix error in config manager

831a503

hiyuchang reviewed May 22, 2025

View reviewed changes

docs/sphinx_doc/source/tutorial/example_reasoning_basic.md Outdated Show resolved Hide resolved

update grpo docs

79dff81

hiyuchang approved these changes May 22, 2025

View reviewed changes

pan-x-c merged commit c389bce into modelscope:main May 22, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reorganize config #46

Reorganize config #46

Uh oh!

pan-x-c commented May 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

pan-x-c commented May 22, 2025

Uh oh!

github-actions bot commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

pan-x-c commented May 22, 2025

Uh oh!

github-actions bot commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pan-x-c commented May 22, 2025

Uh oh!

Uh oh!

github-actions bot commented May 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Reorganize config #46

Reorganize config #46

Uh oh!

Conversation

pan-x-c commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Renamed Fields

Removed Fields

Added Fields

Fixed bugs

Checklist

Uh oh!

Uh oh!

Uh oh!

pan-x-c commented May 22, 2025

Uh oh!

github-actions bot commented May 22, 2025

Summary

Failed Tests

Flaky Tests

Skipped

Tests

Uh oh!

Uh oh!

Uh oh!

pan-x-c commented May 22, 2025

Uh oh!

github-actions bot commented May 22, 2025

Summary

Failed Tests

Flaky Tests

Skipped

Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pan-x-c commented May 22, 2025

Uh oh!

Uh oh!

github-actions bot commented May 22, 2025

Summary

Failed Tests

Flaky Tests

Skipped

Tests

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pan-x-c commented May 21, 2025 •

edited

Loading