Skip to content

Conversation

@ShenQianli
Copy link
Contributor

Description

As the title says.

  • BOTS reference evaluation results collection workflow
  • Data path configuration update in scripts
  • Doc update

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ShenQianli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the BOTS framework by adding an optional feature for collecting and integrating reference model evaluation results. It provides a structured way to evaluate a specified reference model against a dataset, log the performance metrics, and then merge these metrics back into the original dataset as a new feature. This allows for more comprehensive analysis and utilization of reference model performance within the BOTS ecosystem.

Highlights

  • Reference Evaluation Workflow: Introduced a new workflow for collecting reference evaluation results for BOTS, allowing users to evaluate a reference model and integrate its performance metrics.
  • Data Path Configuration: Updated bots.yaml and random.yaml to use manually configurable data paths, replacing previous environment variable placeholders for clarity and user control.
  • Evaluation Result Integration Script: Added a new Python script (ref_eval_collect.py) designed to integrate collected evaluation results into existing datasets, adding them as a new column.
  • Documentation Update: Updated both English and Chinese README.md files with comprehensive instructions on how to set up and run the new reference evaluation process.
  • New Workflow Class: Implemented BOTSRefEvalCollectMathBoxedWorkflow to handle the logging of detailed evaluation results (model version, rewards, question, truth) to a JSONL file, ensuring safe concurrent writes with file locking.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new workflow and script for collecting reference evaluation results and integrating them into existing datasets. It also includes updates to the documentation and data path configurations in bots.yaml and random.yaml. The changes are generally well-structured, but I've identified a critical bug in the new Python script that overrides a command-line argument, a misleading log message, and some maintainability improvements regarding import statements in the new workflow class.

@pan-x-c pan-x-c merged commit 9693926 into modelscope:main Dec 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants