-
Notifications
You must be signed in to change notification settings - Fork 47
Add scripts to search context length capacity on given settings. #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts to search context length capacity on given settings. #423
Conversation
Summary of ChangesHello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust framework for automatically assessing the context length capacity of large language models under various hardware and configuration constraints. By systematically increasing context length and monitoring for OOM conditions, it provides critical insights into model scalability and memory efficiency, which is essential for optimizing model deployment and performance. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Summary of ChangesHello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a robust and automated framework for systematically evaluating the context length scalability of large language models. It provides a Python script that orchestrates distributed training jobs, incrementally increasing context lengths until Out-of-Memory errors are triggered. This system is designed to help researchers and engineers understand and optimize model performance under varying hardware and parallelism settings, utilizing a dedicated dummy workflow to isolate memory usage related to context length, and logging all experimental outcomes for analysis. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new scripts for testing the context length capacity of models. The main script, search_context_length_capacity.py, automates the process of finding the maximum context length by running experiments with increasing lengths. My review focuses on improving the security, robustness, and maintainability of this new script. Key suggestions include refactoring the use of subprocess.Popen to avoid security risks associated with shell=True, replacing rm -rf with a safer Python alternative, and improving the structure of the YAML configuration to reduce duplication. I've also pointed out areas for documentation improvement and code style enhancements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces scripts for automated context length capacity testing. The changes include a new configuration file, a Python script to run the tests, and a dummy workflow. My review focuses on improving the security and maintainability of the new script.
I've identified several high-severity security vulnerabilities in search_context_length_capacity.py:
- The use of
rm -rfis unsafe and can be replaced with a safer Python-native alternative. - The use of
shell=Trueinsubprocess.Popenposes a command injection risk. - There's a path traversal vulnerability when constructing log file paths.
Additionally, I've suggested a refactoring in context_length.yaml to reduce configuration duplication, which will improve maintainability.
Please address these points to make the script more robust and secure.
add `trinity_trainer_configs.md`
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.