-
Notifications
You must be signed in to change notification settings - Fork 47
Add benchmark scripts for Guru-Math #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the benchmarking framework by integrating the Guru-Math task, enabling automated dataset generation, and providing more flexible configuration options. The changes aim to simplify the process of running and evaluating mathematical benchmarks, ensuring consistency and accuracy in performance metrics. It introduces new scripts for data preparation and a sophisticated reward function for grading complex mathematical solutions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds benchmark capabilities for the Guru-Math dataset, which is a great addition. The changes include new configuration files, data generation scripts, and custom reward functions. The automatic data generation for benchmarks is a nice usability improvement. My review includes a few points for improvement:
- The docstring for a new core function in
bench.pycould be clarified. - There's a potential portability issue in
naive_dapo.pydue to a Unix-specific module import, which would prevent the benchmark from running on Windows. - I also found a minor discrepancy between a comment and the code regarding reward values in the new reward logic.
Overall, the changes are well-structured and significantly enhance the benchmarking capabilities of the repository.
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.