-
Notifications
You must be signed in to change notification settings - Fork 47
Add bench results for frozenlake and alfworld #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new benchmark configurations and comprehensive reports for the Alfworld and Frozen Lake environments. These additions provide valuable performance comparisons between the Trinity-RFT framework and rLLM, highlighting Trinity-RFT's efficiency advantages, particularly in the Alfworld environment, by detailing experimental setups and analyzing results. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds benchmark configurations and reports for alfworld and frozenlake. The changes are mostly good, but I have a few suggestions to improve the clarity and consistency of the new files.
In the configuration files, I've suggested a minor change to improve consistency between templates. In the markdown reports, I've pointed out an incomplete sentence, a confusing table, and some minor formatting issues with extra blank lines that affect readability.
Please review my comments for details.
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.