Skip to content

Conversation

@chenyushuo
Copy link
Collaborator

@chenyushuo chenyushuo commented May 16, 2025

Description

  1. Refactor workflow.
  2. Add eval_tasksets for config_manager.py.
  3. Bug fix in vllm_model and vllm_async_model.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@chenyushuo
Copy link
Collaborator Author

/run-unittest

@chenyushuo chenyushuo changed the title [WIP] Refactor workflow Refactor workflow May 19, 2025
@github-actions
Copy link

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
2 1 1 0 0 0 0 11ms

Failed Tests

Failed Tests ❌ Fail Message
❌ tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer The test failed in the call phase due to an exception

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer 7ms

Github Test Reporter by CTRF 💚

@chenyushuo
Copy link
Collaborator Author

/run-unittest

@github-actions
Copy link

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
22 22 0 0 0 0 0 822ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer 4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid 1ms
tests/common/config_test.py::TestConfig::test_load_default_config 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate 45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate 43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate 52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate 52ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate 38ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer 119ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer 152ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool 18ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer 289ms

Github Test Reporter by CTRF 💚

@chenyushuo
Copy link
Collaborator Author

/run-unittest

@github-actions
Copy link

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
22 22 0 0 0 0 0 691ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer 4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid 1ms
tests/common/config_test.py::TestConfig::test_load_default_config 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate 44ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate 43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate 52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate 53ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate 39ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer 76ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer 123ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool 17ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer 229ms

Github Test Reporter by CTRF 💚

Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit dcbc769 into modelscope:main May 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants