Add chat_template_path and trust_remote_code

[hiyuchang]

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

• Code has passed all tests
• Docstrings have been added/updated in Google Style
• Documentation has been updated
• Code is ready for review

[gemini-code-assist]

Summary of Changes

Hello @hiyuchang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new configuration options to enhance flexibility and security within the system. It allows users to specify chat templates via a file path, enabling dynamic loading of custom templates. Additionally, a trust_remote_code flag has been implemented across relevant model configurations, providing explicit control over the execution of remote code when interacting with Hugging Face components, which is crucial for managing potential security risks.

Highlights

• Chat Template Loading from File: Introduced a chat_template_path configuration option to allow specifying a file path for custom chat templates. If provided, the content of this file is loaded and used as the custom_chat_template.
• Trust Remote Code Flag: Added a trust_remote_code boolean flag to various configuration models (Data, ActorModel, CriticModel) and integrated it into the Hugging Face tokenizer and processor initialization. This flag controls whether remote code can be executed when loading models, enhancing security.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces chat_template_path and trust_remote_code configuration options. The changes correctly propagate these new settings. My review includes feedback on adding error handling for file operations to prevent crashes from invalid paths, a minor style fix in a comment, and a suggestion to use more idiomatic attribute access for OmegaConf objects for better readability and maintainability.

[hiyuchang]

/unittest-module-common

[github-actions]

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
35	32	3	0	0	0	4m 57s

Failed Tests

Failed Tests ❌	Fail Message
❌ tests/common/vllm_test.py::ModelWrapperTest_0::test_generate	The test failed in the call phase due to an assertion error
❌ tests/common/vllm_test.py::ModelWrapperTest_1::test_generate	The test failed in the call phase due to an assertion error
❌ tests/common/vllm_test.py::ModelWrapperTest_2::test_generate	The test failed in the call phase due to an assertion error

Tests

Test Name	Status	Flaky	Duration
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅		41.5s
tests/common/config_test.py::TestConfig::test_chat_template_path	✅		91ms
tests/common/config_test.py::TestConfig::test_config_flatten	✅		38ms
tests/common/config_test.py::TestConfig::test_continue_from_checkpoint_is_valid	✅		189ms
tests/common/config_test.py::TestConfig::test_default_workflow	✅		89ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅		3.4s
tests/common/config_test.py::TestConfig::test_max_token_len_per_gpu_set_correctly	✅		90ms
tests/common/config_test.py::TestConfig::test_optimizer_config_propagation	✅		91ms
tests/common/config_test.py::TestConfig::test_update_config_from_ray_cluster	✅		2.2s
tests/common/experience_test.py::TestEID::test_eid_properties	✅		1ms
tests/common/experience_test.py::TestExperience::test_action_mask_and_logprobs_type	✅		1ms
tests/common/experience_test.py::TestExperience::test_assertions	✅		1ms
tests/common/experience_test.py::TestExperience::test_dpo_experience	✅		1ms
tests/common/experience_test.py::TestExperience::test_gather	✅		1ms
tests/common/experience_test.py::TestExperience::test_hf_datasets_conversion	✅		15ms
tests/common/experience_test.py::TestExperience::test_multi_turn_experience	✅		1ms
tests/common/experience_test.py::TestExperience::test_serialize_deserialize	✅		2ms
tests/common/experience_test.py::TestExperience::test_single_turn_experience	✅		1ms
tests/common/experience_test.py::TestExperience::test_to_dict	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_dpo_experience_batch_conversion	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_gather_experiences_with_custom_fields	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_multiturn_experience_batch_converstion	✅		1ms
tests/common/vllm_test.py::ModelWrapperTest_0::test_generate	❌		51.8s
tests/common/vllm_test.py::ModelWrapperTest_1::test_generate	❌		31.4s
tests/common/vllm_test.py::ModelWrapperTest_2::test_generate	❌		42.8s
tests/common/vllm_test.py::TestModelLen_0::test_model_len	✅		18.0s
tests/common/vllm_test.py::TestModelLen_1::test_model_len	✅		17.8s
tests/common/vllm_test.py::TestAPIServer::test_api	✅		22.7s
tests/common/vllm_test.py::TestAsyncAPIServer::test_api_async	✅		23.0s
tests/common/vllm_test.py::TestTokenizer::test_action_mask	✅		272ms
tests/common/vllm_test.py::TestTokenizer::test_action_mask_with_tools	✅		265ms
tests/common/vllm_test.py::TestAPIServerToolCall_0_deepseek_r1::test_api_tool_calls	✅		19.9s
tests/common/vllm_test.py::TestAPIServerToolCall_1::test_api_tool_calls	✅		17.8s

Github Test Reporter by CTRF 💚

[hiyuchang]

/unittest-module-common

[github-actions]

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
36	36	0	0	0	0	5m 17s

Tests

Test Name	Status	Flaky	Duration
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅		41.3s
tests/common/config_test.py::TestConfig::test_chat_template_path	✅		91ms
tests/common/config_test.py::TestConfig::test_config_flatten	✅		38ms
tests/common/config_test.py::TestConfig::test_continue_from_checkpoint_is_valid	✅		445ms
tests/common/config_test.py::TestConfig::test_default_workflow	✅		88ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅		3.8s
tests/common/config_test.py::TestConfig::test_max_token_len_per_gpu_set_correctly	✅		90ms
tests/common/config_test.py::TestConfig::test_optimizer_config_propagation	✅		89ms
tests/common/config_test.py::TestConfig::test_update_config_from_ray_cluster	✅		1.6s
tests/common/experience_test.py::TestEID::test_eid_properties	✅		1ms
tests/common/experience_test.py::TestExperience::test_action_mask_and_logprobs_type	✅		1ms
tests/common/experience_test.py::TestExperience::test_assertions	✅		1ms
tests/common/experience_test.py::TestExperience::test_dpo_experience	✅		1ms
tests/common/experience_test.py::TestExperience::test_gather	✅		1ms
tests/common/experience_test.py::TestExperience::test_hf_datasets_conversion	✅		15ms
tests/common/experience_test.py::TestExperience::test_multi_turn_experience	✅		1ms
tests/common/experience_test.py::TestExperience::test_serialize_deserialize	✅		2ms
tests/common/experience_test.py::TestExperience::test_single_turn_experience	✅		1ms
tests/common/experience_test.py::TestExperience::test_to_dict	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_dpo_experience_batch_conversion	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_gather_experiences_with_custom_fields	✅		1ms
tests/common/experience_test.py::TestExperienceConversion::test_multiturn_experience_batch_converstion	✅		1ms
tests/common/vllm_test.py::ModelWrapperTest_0::test_generate	✅		54.3s
tests/common/vllm_test.py::ModelWrapperTest_1::test_generate	✅		31.6s
tests/common/vllm_test.py::ModelWrapperTest_2::test_generate	✅		43.4s
tests/common/vllm_test.py::TestModelLen_0::test_model_len	✅		17.5s
tests/common/vllm_test.py::TestModelLen_1::test_model_len	✅		17.0s
tests/common/vllm_test.py::TestAPIServer::test_api	✅		22.4s
tests/common/vllm_test.py::TestLogprobs::test_logprobs	✅		19.1s
tests/common/vllm_test.py::TestAsyncAPIServer::test_api_async	✅		22.6s
tests/common/vllm_test.py::TestTokenizer::test_action_mask	✅		261ms
tests/common/vllm_test.py::TestTokenizer::test_action_mask_with_tools	✅		238ms
tests/common/vllm_test.py::TestAPIServerToolCall_0_deepseek_r1::test_api_tool_calls	✅		19.9s
tests/common/vllm_test.py::TestAPIServerToolCall_1::test_api_tool_calls	✅		17.7s

Github Test Reporter by CTRF 💚