-
Notifications
You must be signed in to change notification settings - Fork 47
Update main readme #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main readme #374
Conversation
Summary of ChangesHello @yanxi-chen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a substantial update to the project's primary documentation, encompassing both the English and Chinese README files and their corresponding Sphinx documentation source files. The core objective is to present a more organized, detailed, and user-friendly overview of the Trinity-RFT framework. This includes clarifying the roles of its key components, elaborating on its utility for various user personas, and providing a significantly improved, categorized guide to available tutorials and resources. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request revises the introductory sections of the README files (both English and Chinese) and their corresponding Sphinx documentation source files. The changes improve the structure by reorganizing the 'What is Trinity-RFT?' section and adding a comprehensive 'Tutorials and Guidelines' table, which is a great addition for users. The English documentation changes look good. I've found a few issues in the Chinese documentation files (README_zh.md and docs/sphinx_doc/source_zh/main.md), including some incorrect links and a typo, and have provided suggestions to fix them.
Description
Revise the beginning parts of main readme.
Checklist
Please check the following items before code is ready to be reviewed.