Fix taskset and eval_tasksets path #367

hiyuchang · 2025-11-05T04:16:41Z

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

Code has passed all tests
Docstrings have been added/updated in Google Style
Documentation has been updated
Code is ready for review

gemini-code-assist · 2025-11-05T04:16:54Z

Summary of Changes

Hello @hiyuchang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the clarity and user guidance for path configurations within example YAML files. It modifies the dapo.yaml to provide a more direct placeholder for evaluation taskset paths and adds a descriptive comment to the dpo.yaml file, ensuring users can more easily understand and configure dataset locations.

Highlights

Configuration Path Clarity: The eval_tasksets path in examples/dapo_math/dapo.yaml has been updated to use a more explicit placeholder, /PATH/TO/AIME2024/, instead of an environment variable, making it clearer for users to specify the required path.
DPO Dataset Path Comment: A clarifying comment, # Path to the DPO dataset, was added to the path configuration in examples/dpo_humanlike/dpo.yaml to better explain the purpose of the TRINITY_TASKSET_PATH environment variable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request aims to fix a path in the DAPO example configuration. While a helpful comment was added in dpo.yaml, the change in dapo.yaml replaces a flexible environment variable with a hardcoded placeholder path. This makes the example harder to use, and I've recommended reverting this specific change to maintain better configuration practices.

examples/dapo_math/dapo.yaml

hiyuchang · 2025-11-05T06:24:18Z

/unittest-module-common

github-actions · 2025-11-05T06:30:41Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
33	33	0	0	0	0	4m 54s

Tests

Test Name	Status	Duration
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅	40.5s
tests/common/config_test.py::TestConfig::test_config_flatten	✅	39ms
tests/common/config_test.py::TestConfig::test_continue_from_checkpoint_is_valid	✅	186ms
tests/common/config_test.py::TestConfig::test_default_workflow	✅	87ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅	3.5s
tests/common/config_test.py::TestConfig::test_max_token_len_per_gpu_set_correctly	✅	89ms
tests/common/config_test.py::TestConfig::test_update_config_from_ray_cluster	✅	1.9s
tests/common/experience_test.py::TestEID::test_eid_properties	✅	1ms
tests/common/experience_test.py::TestExperience::test_action_mask_and_logprobs_type	✅	1ms
tests/common/experience_test.py::TestExperience::test_assertions	✅	1ms
tests/common/experience_test.py::TestExperience::test_dpo_experience	✅	1ms
tests/common/experience_test.py::TestExperience::test_gather	✅	1ms
tests/common/experience_test.py::TestExperience::test_hf_datasets_conversion	✅	16ms
tests/common/experience_test.py::TestExperience::test_multi_turn_experience	✅	1ms
tests/common/experience_test.py::TestExperience::test_serialize_deserialize	✅	1ms
tests/common/experience_test.py::TestExperience::test_single_turn_experience	✅	1ms
tests/common/experience_test.py::TestExperience::test_to_dict	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_dpo_experience_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_gather_experiences_with_custom_fields	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_multiturn_experience_batch_converstion	✅	1ms
tests/common/vllm_test.py::ModelWrapperTest_0::test_generate	✅	51.5s
tests/common/vllm_test.py::ModelWrapperTest_1::test_generate	✅	32.8s
tests/common/vllm_test.py::ModelWrapperTest_2::test_generate	✅	42.4s
tests/common/vllm_test.py::TestModelLen_0::test_model_len	✅	17.4s
tests/common/vllm_test.py::TestModelLen_1::test_model_len	✅	16.9s
tests/common/vllm_test.py::TestAPIServer::test_api	✅	22.6s
tests/common/vllm_test.py::TestAsyncAPIServer::test_api_async	✅	22.4s
tests/common/vllm_test.py::TestTokenizer::test_action_mask	✅	269ms
tests/common/vllm_test.py::TestTokenizer::test_action_mask_with_tools	✅	246ms
tests/common/vllm_test.py::TestAPIServerToolCall_0_deepseek_r1::test_api_tool_calls	✅	19.4s
tests/common/vllm_test.py::TestAPIServerToolCall_1::test_api_tool_calls	✅	17.9s

Github Test Reporter by CTRF 💚

pan-x-c · 2025-11-05T06:44:49Z

/unittest-module-common

github-actions · 2025-11-05T06:51:42Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
33	33	0	0	0	0	5m 24s

Tests

Test Name	Status	Duration
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅	41.1s
tests/common/config_test.py::TestConfig::test_config_flatten	✅	39ms
tests/common/config_test.py::TestConfig::test_continue_from_checkpoint_is_valid	✅	187ms
tests/common/config_test.py::TestConfig::test_default_workflow	✅	88ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅	30.8s
tests/common/config_test.py::TestConfig::test_max_token_len_per_gpu_set_correctly	✅	91ms
tests/common/config_test.py::TestConfig::test_update_config_from_ray_cluster	✅	1.8s
tests/common/experience_test.py::TestEID::test_eid_properties	✅	1ms
tests/common/experience_test.py::TestExperience::test_action_mask_and_logprobs_type	✅	1ms
tests/common/experience_test.py::TestExperience::test_assertions	✅	1ms
tests/common/experience_test.py::TestExperience::test_dpo_experience	✅	1ms
tests/common/experience_test.py::TestExperience::test_gather	✅	1ms
tests/common/experience_test.py::TestExperience::test_hf_datasets_conversion	✅	16ms
tests/common/experience_test.py::TestExperience::test_multi_turn_experience	✅	1ms
tests/common/experience_test.py::TestExperience::test_serialize_deserialize	✅	1ms
tests/common/experience_test.py::TestExperience::test_single_turn_experience	✅	1ms
tests/common/experience_test.py::TestExperience::test_to_dict	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_dpo_experience_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_gather_experiences_with_custom_fields	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_multiturn_experience_batch_converstion	✅	1ms
tests/common/vllm_test.py::ModelWrapperTest_0::test_generate	✅	52.2s
tests/common/vllm_test.py::ModelWrapperTest_1::test_generate	✅	32.0s
tests/common/vllm_test.py::ModelWrapperTest_2::test_generate	✅	43.0s
tests/common/vllm_test.py::TestModelLen_0::test_model_len	✅	17.5s
tests/common/vllm_test.py::TestModelLen_1::test_model_len	✅	17.5s
tests/common/vllm_test.py::TestAPIServer::test_api	✅	22.5s
tests/common/vllm_test.py::TestAsyncAPIServer::test_api_async	✅	23.3s
tests/common/vllm_test.py::TestTokenizer::test_action_mask	✅	257ms
tests/common/vllm_test.py::TestTokenizer::test_action_mask_with_tools	✅	269ms
tests/common/vllm_test.py::TestAPIServerToolCall_0_deepseek_r1::test_api_tool_calls	✅	19.6s
tests/common/vllm_test.py::TestAPIServerToolCall_1::test_api_tool_calls	✅	17.5s

Github Test Reporter by CTRF 💚

fix dapo eval_sets path

968d556

gemini-code-assist bot reviewed Nov 5, 2025

View reviewed changes

examples/dapo_math/dapo.yaml Outdated Show resolved Hide resolved

add ENV_VAR

fe259cb

hiyuchang changed the title ~~Fix dapo eval_tasksets path~~ Fix taskset and eval_tasksets path Nov 5, 2025

fix aime

7c108a8

hiyuchang added 2 commits November 5, 2025 14:36

add discription for path

c265ff4

add hf link

502f9f0

pan-x-c approved these changes Nov 5, 2025

View reviewed changes

pan-x-c merged commit c670d0a into modelscope:main Nov 5, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix taskset and eval_tasksets path #367

Fix taskset and eval_tasksets path #367

Uh oh!

hiyuchang commented Nov 5, 2025

Uh oh!

gemini-code-assist bot commented Nov 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

hiyuchang commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

pan-x-c commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix taskset and eval_tasksets path #367

Fix taskset and eval_tasksets path #367

Uh oh!

Conversation

hiyuchang commented Nov 5, 2025

Description

Checklist

Uh oh!

gemini-code-assist bot commented Nov 5, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

hiyuchang commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Summary

Tests

Uh oh!

pan-x-c commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Summary

Tests

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants