-
Notifications
You must be signed in to change notification settings - Fork 47
Add learn_to_ask example
#356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new learn2ask example, including data preparation scripts, workflow logic, prompts, and configuration. The implementation is comprehensive, but there are several areas for improvement. I've identified a critical bug in the evaluation script that will cause a KeyError, and some high-severity issues related to data processing robustness, scalability, and use of global variables in the workflow. I've also included several medium-severity suggestions to improve code quality, maintainability, and correctness across the new files. My feedback includes code suggestions to address these points.
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
yxdyc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory name should be consistent with arXiv version: examples/learn_to_ask.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the learn2ask example, including data preparation scripts, workflow definitions, and configuration files. While the example is comprehensive, there are several critical issues that will prevent it from running correctly. These include bugs that will cause crashes due to incorrect data handling and inconsistent data formats between scripts, as well as a major performance bottleneck from repeatedly initializing a large language model inside a loop. Additionally, there are several high-severity issues such as broken links and incorrect paths in the documentation, and invalid model names in the configuration. I've also pointed out some medium-severity issues related to code quality, like the use of global state, code duplication, and redundant method calls. Addressing these points will be crucial for making the example functional, performant, and maintainable.
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.