Skip to content

Conversation

@yanxi-chen
Copy link
Collaborator

Description

Revise documentation of rec_gsm8k example, and remove rec_math example since it's mostly repetitive.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yanxi-chen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the example documentation and structure within the repository. It primarily focuses on enhancing the clarity and accuracy of the rec_gsm8k example's documentation, providing more precise descriptions of the various group-relative REINFORCE algorithms and their underlying principles, and adding a relevant academic citation. Concurrently, a redundant rec_math example has been removed to reduce duplication and maintain a cleaner codebase. A minor configuration adjustment was also made in the gsm8k.yaml file.

Highlights

  • Documentation Update: The rec_gsm8k example's README.md has been significantly revised to provide clearer descriptions of group-relative REINFORCE variants and their families (REC, REP, RED), along with an academic citation.
  • Example Removal: The rec_math example, including its README.md and math.yaml configuration, has been removed due to its repetitive nature.
  • Configuration Adjustment: The gsm8k.yaml configuration file was updated to set the default clip_mode to "one-side" instead of "none".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the rec_gsm8k example and removes the now-redundant rec_math example. The changes significantly improve the clarity and structure of the documentation by providing more detailed descriptions of the algorithm families and consistent formatting for the configuration examples. I've left a few minor suggestions to further improve the consistency of the markdown formatting. Overall, this is a great cleanup and documentation improvement.

@pan-x-c pan-x-c merged commit cec5a68 into modelscope:main Oct 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants