Simplify Buffer and Explorer Config #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the configuration for the Buffer and Explorer components by consolidating related settings, removing outdated parameters, and updating all relevant examples and documentation. The primary goal is to simplify the configuration experience and ensure consistency with current best practices, making the system easier to understand and use. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies buffer and explorer configurations by refactoring several parameters. The changes move default settings for workflow and reward functions to be more closely associated with tasksets, and removes several deprecated or redundant fields like sft_warmup_*, system_prompt, and reply_prefix from the configuration classes. The runner_num parameter is also consistently renamed to runner_per_model across various example and documentation files.
The code changes in Python files are clean and effectively centralize configuration logic. The updates to the YAML configuration files across the examples are consistent with these changes.
My review focuses on the documentation, where I found a few inconsistencies and minor errors. Specifically, there are discrepancies in runner_per_model values between the English and Chinese documentation, an incomplete item in one of the markdown files, and an inconsistent example. Addressing these will improve the clarity and correctness of the documentation.
Collaborator
Author
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-common |
Summary
Tests
Github Test Reporter by CTRF 💚 |
yanxi-chen
reviewed
Oct 22, 2025
hiyuchang
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please check the following items before code is ready to be reviewed.