Fix absmethod in workflow #297

chenyushuo · 2025-09-23T06:25:01Z

Description

As the title says. Fix for #296

Checklist

Please check the following items before code is ready to be reviewed.

Code has passed all tests
Docstrings have been added/updated in Google Style
Documentation has been updated
Code is ready for review

gemini-code-assist · 2025-09-23T06:25:16Z

Summary of Changes

Hello @chenyushuo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of abstract methods within the workflow classes, specifically in step_wise_workflow.py and workflow.py. The change involves removing the @abstractmethod decorator from several methods and properties, and instead, these methods are now designed to explicitly raise a NotImplementedError if not overridden by subclasses. This modification aims to refine the contract for workflow implementations, potentially allowing for more flexible inheritance patterns or providing clearer runtime feedback for unimplemented methods. Additionally, a minor formatting adjustment was made in model.py to enhance code readability.

Highlights

Abstract Method Refactoring: The @abstractmethod decorator has been removed from several methods and properties across step_wise_workflow.py and workflow.py.
Explicit Unimplemented Method Handling: Methods that were previously marked as abstract and had a pass body now explicitly raise NotImplementedError, providing clearer runtime feedback if not overridden.
Minor Code Formatting: A small cosmetic change was applied to an f-string in trinity/common/models/model.py for improved readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly replaces @abstractmethod with raise NotImplementedError in the workflow base classes. This is a good improvement, as it makes the API contract explicit for subclasses without forcing the use of abc.ABC and prevents silent failures from empty pass statements. The changes are consistent across the codebase. I have one suggestion for further consistency regarding the Workflow class still inheriting from ABC. Additionally, I've noted a potential pre-existing bug in AsyncRewardPropagationWorkflow.run_async that is highly relevant to your changes: it calls self.reward() instead of await self.reward_async(), which will cause a runtime error.

trinity/common/workflows/workflow.py

chenyushuo · 2025-09-23T07:15:08Z

/unittest-module-explorer

github-actions · 2025-09-23T07:24:24Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
30	30	0	0	0	0	487ms

Tests

Test Name	Status	Duration
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	60ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	56ms
tests/explorer/explorer_test.py::TestExplorerGSM8k::test_explorer	✅	206ms
tests/explorer/explorer_test.py::ServeTest::test_serve	✅	66ms
tests/explorer/scheduler_test.py::SchedulerTest::test_async_workflow	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_concurrent_operations	✅	3ms
tests/explorer/scheduler_test.py::SchedulerTest::test_get_results	✅	22ms
tests/explorer/scheduler_test.py::SchedulerTest::test_multi_step_execution	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_non_repeatable_workflow	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_scheduler_all_methods	✅	14ms
tests/explorer/scheduler_test.py::SchedulerTest::test_scheduler_restart_after_stop	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_split_tasks	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_stepwise_experience_eid	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_wait_all	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_wait_all_timeout_with_multi_batch	✅	12ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_reward_propagation_workflow_0	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_reward_propagation_workflow_1	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_step_wise_reward_workflow_0	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_step_wise_reward_workflow_1	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_workflows_raise_error	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_workflows_stop_at_max_env_steps	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_boxed_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_eval_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_rm_gallery_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_repeatable	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable	✅	1ms

Github Test Reporter by CTRF 💚

chenyushuo · 2025-09-23T07:37:35Z

/unittest-module-explorer

github-actions · 2025-09-23T07:46:59Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
32	32	0	0	0	0	494ms

Tests

Test Name	Status	Duration
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	67ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	54ms
tests/explorer/explorer_test.py::TestExplorerGSM8k::test_explorer	✅	205ms
tests/explorer/explorer_test.py::ServeTest::test_serve	✅	67ms
tests/explorer/scheduler_test.py::SchedulerTest::test_async_workflow	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_concurrent_operations	✅	3ms
tests/explorer/scheduler_test.py::SchedulerTest::test_get_results	✅	22ms
tests/explorer/scheduler_test.py::SchedulerTest::test_multi_step_execution	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_non_repeatable_workflow	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_scheduler_all_methods	✅	14ms
tests/explorer/scheduler_test.py::SchedulerTest::test_scheduler_restart_after_stop	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_split_tasks	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_stepwise_experience_eid	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_wait_all	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_wait_all_timeout_with_multi_batch	✅	12ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_reward_propagation_workflow_0	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_reward_propagation_workflow_1	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_step_wise_reward_workflow_0	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_step_wise_reward_workflow_1	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_workflows_raise_error	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_workflows_stop_at_max_env_steps	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_boxed_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_eval_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_rm_gallery_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_repeatable_0	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_repeatable_1	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable_0	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable_1	✅	1ms

Github Test Reporter by CTRF 💚

chenyushuo · 2025-09-23T09:15:01Z

/unittest-module-explorer

github-actions · 2025-09-23T09:25:03Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
34	34	0	0	0	0	531ms

Tests

Test Name	Status	Duration
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	58ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	61ms
tests/explorer/explorer_test.py::TestExplorerGSM8k::test_explorer	✅	203ms
tests/explorer/explorer_test.py::ServeTest::test_serve	✅	68ms
tests/explorer/scheduler_test.py::SchedulerTest::test_async_workflow	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_concurrent_operations	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_get_results	✅	22ms
tests/explorer/scheduler_test.py::SchedulerTest::test_multi_step_execution	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_non_repeatable_workflow	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_scheduler_all_methods	✅	13ms
tests/explorer/scheduler_test.py::SchedulerTest::test_scheduler_restart_after_stop	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_split_tasks	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_stepwise_experience_eid	✅	4ms
tests/explorer/scheduler_test.py::SchedulerTest::test_wait_all	✅	7ms
tests/explorer/scheduler_test.py::SchedulerTest::test_wait_all_timeout_with_multi_batch	✅	13ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_reward_propagation_workflow_0	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_reward_propagation_workflow_1	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_step_wise_reward_workflow_0	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_step_wise_reward_workflow_1	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_workflows_raise_error	✅	1ms
tests/explorer/step_wise_workflow_test.py::WorkflowTest::test_workflows_stop_at_max_env_steps	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_boxed_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_eval_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_rm_gallery_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_repeatable_0	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_repeatable_1	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable_0	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable_1	✅	1ms
tests/explorer/workflow_test.py::MultiTurnWorkflowTest_0::test_multi_turn_workflow	✅	19ms
tests/explorer/workflow_test.py::MultiTurnWorkflowTest_1::test_multi_turn_workflow	✅	19ms

Github Test Reporter by CTRF 💚

pan-x-c

LGTM

Fix absmethod in workflow

df0bad4

gemini-code-assist bot reviewed Sep 23, 2025

View reviewed changes

trinity/common/workflows/workflow.py Outdated Show resolved Hide resolved

add unittest && bug fix

e4ad44d

add async workflow test

61048c7

add MultiTurnWorkflowTest

bf33180

pan-x-c approved these changes Sep 23, 2025

View reviewed changes

pan-x-c merged commit 4132f0c into modelscope:main Sep 23, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix absmethod in workflow #297

Fix absmethod in workflow #297

Uh oh!

chenyushuo commented Sep 23, 2025

Uh oh!

gemini-code-assist bot commented Sep 23, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

chenyushuo commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

chenyushuo commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

chenyushuo commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

pan-x-c left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix absmethod in workflow #297

Fix absmethod in workflow #297

Uh oh!

Conversation

chenyushuo commented Sep 23, 2025

Description

Checklist

Uh oh!

gemini-code-assist bot commented Sep 23, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

chenyushuo commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Summary

Tests

Uh oh!

chenyushuo commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Summary

Tests

Uh oh!

chenyushuo commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025

Summary

Tests

Uh oh!

pan-x-c left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants