Skip to content

Conversation

@garyzhang99
Copy link
Collaborator

Description

As the title says.

We update an example compatible with agentscope-v1. The example for agentscope-v0 is kept but might be deprecated in the future.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @garyzhang99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the integration with the AgentScope framework by introducing compatibility with its V1 version. It provides an updated example workflow for React agents, ensuring that the project leverages the latest features and best practices from AgentScope, while gracefully phasing out the older V0-based example.

Highlights

  • AgentScope V1 Compatibility: Introduced a new AgentScopeReactMathWorkflow to support AgentScope V1, providing an updated example for integration.
  • Deprecation of AgentScope V0 Example: The existing AgentScopeReactV2MathWorkflow (AgentScope V0) has been marked for deprecation, with a new file added for the V1 version.
  • Documentation Update: The example_react.md tutorial has been updated to reflect the changes, including new class names, an async client note, and results from training with Qwen3-4B on the V1 workflow.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates an agentscope example to be compatible with v1, while deprecating the v0 version. The changes include adding a new workflow for v1, updating documentation, and modifying related imports. My review focuses on improving code quality in the new workflow file by addressing code duplication, string formatting, and function structure. I also point out a typo in the updated documentation.

@pan-x-c pan-x-c merged commit e06798b into modelscope:main Sep 15, 2025
2 checks passed
yaochaorui pushed a commit to yaochaorui/Trinity-RFT that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants