Cleaning up the old-version data processor #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @HYLcool, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant cleanup and refactoring of the data processing module. The primary goal is to remove an outdated version of the data processor and its associated components, streamlining the codebase. Concurrently, the documentation has been updated to accurately reflect the current unified data processor architecture, which leverages Data-Juicer for various data handling tasks. This change improves code maintainability and clarity by eliminating deprecated functionalities and providing up-to-date guidance.
Highlights
- Major Refactoring of Data Processing Module: The pull request undertakes a significant refactoring of the data processing module, removing several older components such as
DataActiveIterator,DataTaskParser,DataCleaner,DataSynthesizer,RftDataset, and their associated test files. This indicates a strategic shift towards a more streamlined and potentially unified data processing architecture. - Documentation Updates: Documentation has been updated to reflect the current state of the data processor. This includes a new 'Overview' section in
example_data_functionalities.mdexplaining Trinity-RFT's unified data processor and its integration with Data-Juicer, as well as clarifications on operator concepts intrinity_programming_guide.md. - Configuration and Constant Streamlining: The configuration and constant definitions have been streamlined. Specifically,
RewardShapingConfigandDataPipelineConfigdataclasses were removed fromtrinity/common/config.py, and theDataProcessorPipelineTypeenum values intrinity/common/constants.pywere simplified for better consistency. - Code Modernization and Cleanup: Existing code that interacts with the data processing pipeline has been updated to align with the new architecture. This includes changes in
DataJuicerOperatorandTaskPipelineto utilize the simplifiedDataProcessorPipelineTypeenum, ensuring compatibility with the removed older data processor components.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively cleans up the old data processor, replacing it with a more streamlined, service-based architecture centered around DataJuicerOperator. The removal of numerous legacy files significantly simplifies the codebase, and the accompanying documentation updates are helpful. My review includes a couple of suggestions to enhance the documentation's clarity and long-term stability.
docs/sphinx_doc/source/tutorial/example_data_functionalities.md
Outdated
Show resolved
Hide resolved
* update the link to the data processor arch
Collaborator
|
/unittest-all |
Summary
Tests
Github Test Reporter by CTRF 💚 |
pan-x-c
approved these changes
Aug 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes the old-version data processor components and updates documentation. The cleanup involves removing outdated data processing modules that are no longer needed, including the data server, processors, controllers, and related test files.
- Removed old data processing server and pipeline components
- Deleted legacy data processor classes and their tests
- Updated documentation to reflect current data processing architecture
- Cleaned up unused configuration classes and constants
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| trinity/data/server.py | Removed Flask-based data processing server |
| trinity/data/readme.md | Removed outdated data engine documentation |
| trinity/data/processors/*.py | Removed legacy data processor classes (synthesizer, annotator, cleaner, base) |
| trinity/data/core/*.py | Removed old core data classes (formatter, dataset, comparator) |
| trinity/data/controllers/*.py | Removed task parser and active iterator controllers |
| trinity/common/constants.py | Removed DataProcessorPipelineType enum |
| trinity/common/config.py | Removed data pipeline configuration classes |
| tests/data/ | Removed all test files for legacy data processing components |
| docs/ | Updated documentation to reflect current data processing architecture |
Comments suppressed due to low confidence (3)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yaochaorui
pushed a commit
to yaochaorui/Trinity-RFT
that referenced
this pull request
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title says. And updating some docs about data processor.
Checklist
Please check the following items before code is ready to be reviewed.