-
Notifications
You must be signed in to change notification settings - Fork 47
Add tool call usage from our vllm model #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @garyzhang99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for OpenAI-compatible tool calls within our vLLM model integration. It enables the model to understand and respond to function calls, allowing for more dynamic and interactive AI capabilities by leveraging external tools.
Highlights
- Tool Call Configuration: Introduced new configuration options (
enable_auto_tool_choiceandtool_call_parser) to control the behavior of OpenAI-compatible tool calls for vLLM models. - vLLM API Server Integration: Extended the vLLM API server to accept and utilize these new tool call configuration parameters, allowing the underlying vLLM engine to process tool calls and function definitions.
- Comprehensive Tool Call Testing: Added a new end-to-end test case (
test_api_tool_calls) that simulates a full OpenAI API tool call workflow, including tool definition, model decision to call a tool, simulated tool execution, and the model's final natural language response based on the tool's output. - UI Exposure: Integrated the new tool call configuration options into the configuration management system, making them accessible and configurable via the user interface.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for tool calls using an OpenAI-compatible format with the vLLM model. The changes are well-structured, touching upon configuration, the model wrapper, API patching, and testing. My review has identified a critical issue in the UI configuration logic, a high-severity correctness issue in a test assertion, and several medium-severity items to improve code maintainability and quality. Addressing these points will strengthen the implementation and ensure the new feature is robust.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/unittest-module-common |
Co-authored-by: chenyushuo <[email protected]>
|
/unittest-module-common |
|
/unittest-module-common |
1 similar comment
|
/unittest-module-common |
Summary
Tests
Github Test Reporter by CTRF 💚 |

Description
As the title says. We use an OpenAI-compatible format for our tool calls.
Checklist
Please check the following items before code is ready to be reviewed.